Skip to content

Add ability to run shell before and after deployment - #391

Merged
nikita-petko merged 17 commits into
masterfrom
feature/389-enable-maintenance-on-new-deployment
Aug 13, 2026
Merged

Add ability to run shell before and after deployment#391
nikita-petko merged 17 commits into
masterfrom
feature/389-enable-maintenance-on-new-deployment

Conversation

@nikita-petko

Copy link
Copy Markdown
Contributor

~ Bump CFA to v10
~ Add step to read deployment scripts either as abs or relative paths or raw inline scripts. ~ Run scripts with deployment phase where before scripts will fail the deployment on error, and after scripts won't

…ment

deploy.yml:
~ Bump CFA to v10
~ Add step to read deployment scripts either as abs or relative paths or raw inline scripts.
~ Run scripts with deployment phase where before scripts will fail the deployment on error, and after scripts won't
@nikita-petko nikita-petko linked an issue Aug 13, 2026 that may be closed by this pull request
@github-project-automation github-project-automation Bot moved this to Not Started in GRIDBOT Aug 13, 2026
#!skip-build!#

Add missing js-yaml!
#!skip-build!#

~ Instead of returning file paths (uhhh because job A and B not on same machine :/) use the raw script
~ Write script to file output
~ Use correct component name
#388(@nikita-petko): RSISRIOFAS
#!components: grid-bot-recovery

Update build.yml:
~ Add lib/*

Update .vscode:
~ Add taks and launch configurations for grid-bot-recovery

Update grid-bot component:
~ Add gRPC service endpoint.

Update grid-bot-recovery:
~ Move shard count to a once flag, to run initialization once on startup.
  Please Note: Only interactions will actually respond here for some reason.
~ Allow updates to happen manually instead of always occuring whenever Set() is called.
#!components: grid-bot, grid-bot-recovery

~ Make CheckHealth use google.protobuf.Empty instead
~ Add SetStatus RPC
#!components: grid-bot, grid-bot-recovery

deploy.yml:
~ Pass env to deploy-nomad-jobs step just in case it needs it

grid-bot component:
~ Add set-maintenance-status before script that will set the maintenance status
~ Update gRPC host.
#!components: grid-bot-recovery

workflows:
~ Update build.yml to fully allow multiple components
~ Pass env to read-deployment-scripts

grid-bot component:
~ Fix syntax with pre-env expression.
#!components: grid-bot

grpc:
~ Add correct settings to service provider.

utility:
~ Update MSLogger to also log exception if not null.

grid-bot component:
~ Pre-script error out when either grpcurl not downloaded, or proto-url
…oyment

Signed-off-by: Nikita Petko <petko@vmminfra.net>
~ Add import-path
~ Set maintenance_message
~ Sleep for 5 seconds to ensure propagation
@nikita-petko nikita-petko self-assigned this Aug 13, 2026
Sync get-component-names with rbxinfra/bedev2-service-template
@nikita-petko
nikita-petko merged commit 7562dea into master Aug 13, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Not Started to Complete in GRIDBOT Aug 13, 2026
@nikita-petko nikita-petko added kind: feature This issue integrates a single feature (or multiple disguised as one) priority: deliverable The issue is medium priority, most issues will use this as they see fit. opsec: repo-ops SEC-04-REPOOPS area: code-ops Issue relates to the issue of Code Ops area: ci-cd Issue relates to CI/CD. opsec: ci-cd SEC-19-CI-CD labels Aug 13, 2026
@nikita-petko nikita-petko added this to the SEC-19-CI-CD milestone Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci-cd Issue relates to CI/CD. area: code-ops Issue relates to the issue of Code Ops kind: feature This issue integrates a single feature (or multiple disguised as one) opsec: ci-cd SEC-19-CI-CD opsec: repo-ops SEC-04-REPOOPS priority: deliverable The issue is medium priority, most issues will use this as they see fit.

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

FEATURE: Enable Maintenance on new deployment

1 participant