Skip to content

RSISRIOFAS - #390

Merged
nikita-petko merged 1 commit into
masterfrom
hotfix/388-recovery-should-immediately-start-responding-instead-of-waiting-for-all-shards
Aug 13, 2026
Merged

RSISRIOFAS#390
nikita-petko merged 1 commit into
masterfrom
hotfix/388-recovery-should-immediately-start-responding-instead-of-waiting-for-all-shards

Conversation

@nikita-petko

Copy link
Copy Markdown
Contributor

See #388

#!components: grid-bot-recovery

Update build.yml:
~ Add lib/*

Update .vscode:
~ Add taks and launch configurations for grid-bot-recovery

Update grid-bot component:
~ Add gRPC service endpoint.

Update grid-bot-recovery:
~ Move shard count to a once flag, to run initialization once on startup.
  Please Note: Only interactions will actually respond here for some reason.
@nikita-petko nikita-petko self-assigned this Aug 13, 2026
@nikita-petko nikita-petko added the area: code-ops Issue relates to the issue of Code Ops label Aug 13, 2026
@github-project-automation github-project-automation Bot moved this to Not Started in GRIDBOT Aug 13, 2026
@nikita-petko nikita-petko added priority: key deliverable The issue is high priority and normally has a very close target quarter. opsec: we-love-clean-code SEC-10-WLCC area: discord Issue relates to discord kind: hotfix A bug fix that is to be implemented as fast as possible. Always KD. labels Aug 13, 2026
@nikita-petko nikita-petko moved this from Not Started to On Track in GRIDBOT Aug 13, 2026
@nikita-petko nikita-petko added this to the SEC-10-WLCC milestone Aug 13, 2026
@nikita-petko
nikita-petko merged commit 4915dd9 into master Aug 13, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from On Track to Complete in GRIDBOT Aug 13, 2026
nikita-petko added a commit that referenced this pull request Aug 13, 2026
#388(@nikita-petko): RSISRIOFAS
#!components: grid-bot-recovery

Update build.yml:
~ Add lib/*

Update .vscode:
~ Add taks and launch configurations for grid-bot-recovery

Update grid-bot component:
~ Add gRPC service endpoint.

Update grid-bot-recovery:
~ Move shard count to a once flag, to run initialization once on startup.
  Please Note: Only interactions will actually respond here for some reason.
nikita-petko added a commit that referenced this pull request Aug 13, 2026
#!components: grid-bot, grid-bot-recovery
#!deployable-components: grid-bot

* #389(@nikita-petko): Add ability to run shell before and after deployment

deploy.yml:
~ Bump CFA to v10
~ Add step to read deployment scripts either as abs or relative paths or raw inline scripts.
~ Run scripts with deployment phase where before scripts will fail the deployment on error, and after scripts won't

* #389(@nikita-petko): Update deploy.yml

Add missing js-yaml!

* #389(@nikita-petko): Update deploy.yml

~ Instead of returning file paths (uhhh because job A and B not on same machine :/) use the raw script
~ Write script to file output
~ Use correct component name

* #389(@nikita-petko): Tag with script ID.

* #389(@nikita-petko): Add ability to perform dry-run

* RSISRIOFAS (#390)

#388(@nikita-petko): RSISRIOFAS

Update build.yml:
~ Add lib/*

Update .vscode:
~ Add taks and launch configurations for grid-bot-recovery

Update grid-bot component:
~ Add gRPC service endpoint.

Update grid-bot-recovery:
~ Move shard count to a once flag, to run initialization once on startup.
  Please Note: Only interactions will actually respond here for some reason.

* #389(@nikita-petko): Patch error

* #389(@nikita-petko): Add config update transactions

~ Allow updates to happen manually instead of always occuring whenever Set() is called.

* #389(@nikita-petko): Update protos

~ Make CheckHealth use google.protobuf.Empty instead
~ Add SetStatus RPC

* #389(@nikita-petko): Update deployment related

deploy.yml:
~ Pass env to deploy-nomad-jobs step just in case it needs it

grid-bot component:
~ Add set-maintenance-status before script that will set the maintenance status
~ Update gRPC host.

* #389(@nikita-petko): Update deployment related

workflows:
~ Update build.yml to fully allow multiple components
~ Pass env to read-deployment-scripts

grid-bot component:
~ Fix syntax with pre-env expression.

* #398(@nikita-petko): Pass-down NOMAD_VERSION

* #389(@nikita-petko): Update grid-bot

grpc:
~ Add correct settings to service provider.

utility:
~ Update MSLogger to also log exception if not null.

grid-bot component:
~ Pre-script error out when either grpcurl not downloaded, or proto-url

* #389(@nikita-petko): Update grid-bot component

~ Add import-path
~ Set maintenance_message
~ Sleep for 5 seconds to ensure propagation

* #389(@nikita-petko): Only build when needed.

* #389(@nikita-petko): Sync with @rbxinfra

Sync get-component-names with rbxinfra/bedev2-service-template

---------

Signed-off-by: Nikita Petko <petko@vmminfra.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: code-ops Issue relates to the issue of Code Ops area: discord Issue relates to discord kind: hotfix A bug fix that is to be implemented as fast as possible. Always KD. opsec: we-love-clean-code SEC-10-WLCC priority: key deliverable The issue is high priority and normally has a very close target quarter.

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

HOTFIX: Recovery should immediately start responding instead of waiting for all shards

1 participant