Conversation
…dfd5557aa314d8f029b08bc402862f6c [skip ci] Written by argocd-image-updater for application virtual-pet-dev.
* chore: expose COMMIT_HASH and BUILD_TIME on the health endpoint CI already passed COMMIT_HASH as a docker build-arg, but the Dockerfile never declared the ARG, so the value was discarded and the health check could not report which commit is running. Declare ARG COMMIT_HASH and ARG BUILD_TIME in the final stage and promote both to ENV so they reach the process regardless of the start script, stamp BUILD_TIME in CI, and surface both on /api/system/health. BUILD_TIME identifies the image rather than the container, so unlike serverStartDate it survives restarts and is usable as a release reference. * chore: drop workflow edits, Terraform owns those files The build workflows are generated from config_texts and written by Terraform to dev, which already carries the buildtime step, the BUILD_TIME build-arg and the argo/ paths-ignore guard. Keeping a second copy here only caused merge conflicts and risked reverting paths-ignore. This PR now changes just the Dockerfile and the health route. --------- Co-authored-by: jplorier <jplorier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release PR: merges
devintomain.Labelled
release+patchsoAuto Release on Main Mergecuts a patch release on merge, which in turn triggers the production build.What this carries
BUILD_TIMEbuild-arg +buildtimestep in the build workflows.aws_prod_release.ymlonmainis the file a release build actually uses (the tag points at amaincommit), so prod images only start reporting a build time once this is merged.paths-ignore: ['argo/**']on the dev build trigger — now the only guard against the rebuild loop, since[skip ci]has been removed from the Argo CD Image Updater commit template.devfor this app. Please review the file list before merging; some repos carry unreleased application work.Why the label test matters
Until today,
dev -> mainrelease PRs were being silently dropped: Image Updater stamped[skip ci]on its digest write-back commit, that commit became the tip ofdev, and GitHub applies[skip ci]topull_requestevents too — keyed on the PR HEAD commit. No workflow run, no check suite, no release. Twelve releases had to be cut by hand.[skip ci]has since been removed from the template (infra-terraformk8-mgmt/argo.tf) and replaced by the path filter, and every repo'sdevHEAD has been verified clean of it. Merging this PR with the labels attached is the end-to-end confirmation thatAuto Releasefires on its own again.