Slight improvements on membership endpoints.#159
Merged
Conversation
majst01
reviewed
Jul 15, 2026
Comment on lines
+331
to
+345
| message TenantServiceAddMemberRequest { | ||
| // Login of the tenant to which the member will be added | ||
| string login = 1 [(buf.validate.field).string.(metalstack.api.v2.is_tenant_login) = true]; | ||
| // Login of the member to add | ||
| string member = 2 [(buf.validate.field).string.(metalstack.api.v2.is_tenant_login) = true]; | ||
| // Role to assign to the new member | ||
| TenantRole role = 3 [(buf.validate.field).enum.defined_only = true]; | ||
| } | ||
|
|
||
| // TenantServiceAddMemberResponse is the response payload for the add member request | ||
| message TenantServiceAddMemberResponse { | ||
| // TenantMember is the added tenant member | ||
| TenantMember tenant_member = 1; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Why do we need this for normal users ?
Contributor
Author
There was a problem hiding this comment.
It would be easier when using IaC if owners can just add members without requiring invites.
Contributor
There was a problem hiding this comment.
OK, but do we have use cases? I would prefer not to force us to implement more features right now.
Contributor
Author
There was a problem hiding this comment.
Just wanted to implement the CRUD in the CLI but we can also skip this feature if you want.
Contributor
There was a problem hiding this comment.
I like the additions in the admin endpoint, but would prefer if you create an issue for the later
majst01
marked this pull request as ready for review
July 16, 2026 11:21
majst01
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During CLI implementation I thought some more information coming from the API would be great.
Used AI-Tools ✨