Fix build: restore global File alias hidden by TFT_eSPI's FS_NO_GLOBALS#2973
Open
weebl2000 wants to merge 1 commit into
Open
Fix build: restore global File alias hidden by TFT_eSPI's FS_NO_GLOBALS#2973weebl2000 wants to merge 1 commit into
weebl2000 wants to merge 1 commit into
Conversation
TFT_eSPI's default User_Setup.h enables SMOOTH_FONT, which makes it define FS_NO_GLOBALS before including FS.h. Any TU that includes ST7735Display.h before SPIFFS.h/FS.h (e.g. simple_repeater MyMesh.h via target.h) then loses the global File/FS aliases and fails to compile. Re-export the fs:: aliases right after including TFT_eSPI.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the build on dev was broken trying to build for heltec wireless tracker.