Skip to content

chore: remove phase proofs and workflow policy checker#14

Merged
jmgilman merged 1 commit into
mainfrom
chore/remove-phase-scaffolding
Jul 23, 2026
Merged

chore: remove phase proofs and workflow policy checker#14
jmgilman merged 1 commit into
mainfrom
chore/remove-phase-scaffolding

Conversation

@jmgilman

Copy link
Copy Markdown
Contributor

Summary

First of two cleanup PRs stripping delivery-phase scaffolding so the repo does one thing: publish deb/rpm packages to R2.

  • Delete check_workflow_policy.py + test: it asserted exact string fragments (with exact occurrence counts) of publish.yml and phase5-publish.sh, so every legitimate workflow edit broke it. It cannot protect anything a reviewer doesn't — anyone able to edit the workflow can edit the checker in the same PR.
  • Delete phase 1/2 fixture proofs (phase1-local.sh, phase2-local.sh, testdata/, moon tasks): these ran docker fixture builds, throwaway GPG keygen, and container installs of a fake package on every CI run (~30s+ each, confirmed in run 29972545107) while proving nothing the Go unit tests and the real publish flow don't.
  • Delete phase4-staging.sh + moon task: staging rehearsal pinned to a fixture project, superseded by the staging job in publish.yml.
  • Delete rebuild.yml: manual workflow whose only job was re-running the phase 2 fixture proof.
  • Delete disposable spikes/phase0 artifacts (run.sh, fault-injection.sh, EVIDENCE.md, README.md). Dockerfile.tools and build-repository.sh stay for now because the live publish scripts reference them; they move/shrink in the follow-up PR.
  • Trim phase3-ci.shlint-workflows.sh: keeps pinned actionlint + ShellCheck (cheap, real), drops the policy checker.
  • Update README and docs to match.

No behavior change to the publish path — publish.yml and the phase 5 scripts are untouched here. A follow-up PR simplifies those.

Testing

  • scripts/lint-workflows.sh (actionlint + shellcheck + dispatch-payload test) passes locally.
  • go build ./... and go test ./... pass locally.

🤖 Generated with Claude Code

The phase 1/2/4 fixture proofs, the rebuild validation workflow, and the
string-matching workflow policy checker were delivery-phase scaffolding.
The real publish path (validate -> staging -> production) supersedes them,
and the policy checker's exact-fragment assertions broke on every
legitimate workflow edit.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@jmgilman
jmgilman merged commit 211d286 into main Jul 23, 2026
2 checks passed
@jmgilman
jmgilman deleted the chore/remove-phase-scaffolding branch July 23, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant