Import 3 x imaging instruments from various sources#2569
Conversation
Mads Bertelsen and Victor Holm (EU PaNOSC related work)
|
@jorobledo, @farhi here comes the 3 x imaging instruments discussed elsewhere |
mads-bertelsen
left a comment
There was a problem hiding this comment.
Nice to have these instruments included.
The sword instrument file has some additional details added specifically about ODIN since I saw it, but would be nice if it included credit to me for making the sword.
The refractor instrument is not the final version that was used in Estrids paper, that used union components. As far as I can see, the version included with a group of refractors can work at very low angles, but a ray would not be able to go from one to another. At very low angles reflections would be relevant, but these are disabled. We could contact Estrid for her final version, but this version can still be added. It's probably faster to run.











Free-form text area
Please describe what your PR is adding in terms of features or bugfixes:
Import of:
Radiography_Li_battery(Mads Bertelsen & Viktor Holm)Radiography_Sword(Mads Bertelsen & Viktor Holm)PSI_ICON(Peter Willendrup & Estrid B. Naver)Declaration of use of AI-tools
No AI this time round. Just me… ;-)
Development OS / boundary conditions
Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
macOS Tahoe, conda-forge dev-tools
PR Checklist for contributing to McStas/McXtrace
For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:
My contribution includes a new component file
mcdocutility and rendered a reasonable documentation page for the component (please attach as screenshot in comments!)mccode-clangformattool to apply the standard McCode component indentation schemecontribcomponent categoryMy contribution includes a new instrument file
mcdocutility and rendered a reasonable documentation page for the instrument (please attach as screenshot in comments!)%Example:line to describe expected behaviourmcrun --c-lint"linter" and followed advice to remove most / all warnings that are raisedexampleshierarchy in a folder in the style ofexamples/ESS/New_stuff/New_stuff.instrexamplefolder, but if general use I have placed it in the globaldatafolder.