Skip to content

fix(events): Add an empty state for months with no events - #3419

Merged
joshlarson merged 5 commits into
mainfrom
jdl/fix/empty-state-for-events
Aug 13, 2026
Merged

fix(events): Add an empty state for months with no events#3419
joshlarson merged 5 commits into
mainfrom
jdl/fix/empty-state-for-events

Conversation

@joshlarson

Copy link
Copy Markdown
Contributor

Scope

Asana Ticket: 🗓️ Events page should still show months without events

Implementation

  • Instead of relying exclusively on Enum.group_by, which simply doesn't include entries for months that have no events, we find the earliest and latest relevant months and return a list (possibly empty) of event teasers for each month in between.

Screenshots

Screenshot 2026-08-13 at 2 53 29 PM

How to test

Look at the events page and notice how it doesn't look like we've just forgotten about August.

@joshlarson
joshlarson requested review from a team and amaisano as code owners August 13, 2026 18:56
@joshlarson
joshlarson requested a review from lvachon1 August 13, 2026 18:56
@joshlarson
joshlarson enabled auto-merge (squash) August 13, 2026 18:56
Comment thread lib/dotcom_web/views/event_view.ex
@joshlarson
joshlarson merged commit 14ebccf into main Aug 13, 2026
20 checks passed
@joshlarson
joshlarson deleted the jdl/fix/empty-state-for-events branch August 13, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants