[Fix]: FunctionClauseError: no function clause matching in DotcomWeb.ScheduleController.FinderApi.load_from_repos/2 - #3416
Merged
Conversation
…eters. Added an error message to handle invalid params instead of crashing.
jlucytan
reviewed
Aug 13, 2026
jlucytan
reviewed
Aug 13, 2026
jlucytan
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: QF | FunctionClauseError: no function clause matching in DotcomWeb.ScheduleController.FinderApi.load_from_repos/2
Implementation
Digging around the Sentry logs it appears that when/if invalid or incomplete URL params are supplied to
schedules/finder_api/journeysthe app crashes.Added checks to ensure code only runs when supplied with proper parameters. Added an error message to handle invalid params instead of crashing.
Screenshots
N/A
How to test
Invalid arguments:
http://localhost:4001/schedules/finder_api/journeys?date=2026-08-13&stop=place-sstat&is_current=true&id=1
Valid arguments (empty result)
http://localhost:4001/schedules/finder_api/journeys?date=2026-08-13&stop=place-sstat&is_current=true&id=1&direction=1