Batch fix: 6 easy-tier issues (#11, #6, #8, #17, #5, #7) - #24
Merged
Conversation
saveNameEdit() used a bare fetch(), skipping the shared apiFetch() helper's 401 redirect-to-login behavior that every other call site in this file already relies on. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CdL8gBSztcb3PrPTBbAH1T
scrollToBottom() was only called after the success-proposal branch of doSend(), so error/dry-run/network-failure replies and outgoing user messages didn't scroll the view. Replaced the single call site with a useEffect keyed on messages.length so every append is covered. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CdL8gBSztcb3PrPTBbAH1T
addCustomKey()'s two validation alerts were the only window.alert() use in the app. Both now set the existing configError state, which already renders inline in the same config zone — no new UI needed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CdL8gBSztcb3PrPTBbAH1T
Generated lib/ai/prompts/generated/*.ts used JSON.stringify(), producing
one giant escaped-string line per file. Switched to a template literal
that preserves the source's actual newlines, escaping \, `, and \${ so
the compiled value is unchanged. Verified byte-identical against the
old extraction logic for all three agents (hermes/daedalus/prometheus).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CdL8gBSztcb3PrPTBbAH1T
GuidedTour's autostart and the post-signup ConsentPopup were wired independently, so a fresh signup could land on the tour with the consent modal still stacked on top of it. GuidedTour now only mounts (and can autostart) once tourReady is true — set immediately when no popup is needed, or from ConsentPopup's onClose otherwise. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CdL8gBSztcb3PrPTBbAH1T
The one-time token reveal showed a literal <url> placeholder in the claude mcp add command, and Copy only copied the bare token — pasting the shown command into a CLI didn't work. buildMcpCommand() now fills in the real endpoint (window.location.origin + /api/mcp), and a second "Copy command" button copies the fully-assembled command. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CdL8gBSztcb3PrPTBbAH1T
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Six small, self-contained fixes batched into one PR to cut down on PR/CI/deploy overhead for unrelated one-off issues:
AgentView.tsxsave-name call now goes throughapiFetch(401 redirect no longer skipped)window.alert()in the app with the existing inlineconfigErrorpatternbuild-prompts.tsnow emits readable multi-line template-literal output instead of one escaped-string line (compiled value verified byte-identical)<url>placeholder, and adds a "Copy command" button that copies the fully-assembled, ready-to-paste commandCloses #11, closes #6, closes #8, closes #17, closes #5, closes #7
Test plan
npx tsc --noEmit -p .— cleannpm test(vitest) — 68 files / 880 tests passednpx tsx scripts/build-prompts.ts— regenerated output verified byte-identical to the oldJSON.stringify()extraction for hermes/daedalus/prometheus🤖 Generated with Claude Code
https://claude.ai/code/session_01CdL8gBSztcb3PrPTBbAH1T