Allow exemption of losing certain units contributing to war weariness#52
Open
instafluff0 wants to merge 8 commits into
Open
Allow exemption of losing certain units contributing to war weariness#52instafluff0 wants to merge 8 commits into
instafluff0 wants to merge 8 commits into
Conversation
instafluff0
changed the title
Contributor
Author
|
Fixed, tested and working as expected. |
Contributor
Author
|
I recalled that surviving units with 1 remaining HP also cause war weariness, will patch those cases as well and reopen... |
Contributor
Author
|
Okay, additional HP of 1-related war weariness cases patched, updated, and tested. Reopening... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another minor feature, and zero rush on this: allow users to prevent the loss of certain units from contributing to war weariness. In my personal scenario, this is really about drones, robots and so on, and adds a touch of modernity & realism. It also interestingly makes late-game long wars with Democracies, etc. viable to some extent.
Note that the separate
repl calls and the need foris->war_weariness_fight_contextinFighter_fightare necessary as that is the only function I found where both the attack and defender are assessed for addition of war weariness (if HP drops to 1).