bridgev2/portal: fix stale ghost displayname in member events - #535
Open
Fizzadar wants to merge 1 commit into
Open
bridgev2/portal: fix stale ghost displayname in member events#535Fizzadar wants to merge 1 commit into
Fizzadar wants to merge 1 commit into
Conversation
A room member event whose displayname has drifted from the ghost profile is never repaired: the membership value is unchanged so no member event is sent, and when one is sent it copies the stale cached displayname straight back. Sync joined ghosts whose name differs from the room's current member state, take the displayname and avatar from the ghost when rewriting an existing member event, and skip the invite downgrade for members who are already joined.
Fizzadar
commented
Jul 29, 2026
| if ghost != nil && ok { | ||
| content.Displayname = ghost.Name | ||
| if ghost.AvatarMXC != "" { | ||
| content.AvatarURL = ghost.AvatarMXC |
Member
Author
There was a problem hiding this comment.
Should we also be checking avatar? This function is already pretty complicated..
Perhaps there's a nicer way to do this and separate membership sync from profile.
Member
|
Member events should never drift 🤔 |
Member
Author
I think the problem is specific to gmessages - the ghost names fallback to phone number if not found and then later we get the name. Though now I type that I think that should trigger a profile update anyway which the HS would then propagate to the rooms. In which case maybe it's a nameSet=true comparison issue or something... |
Contributor
|
I also have a similar problem with the snapchat bridge and this seems very similar to my patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A room member event whose displayname has drifted from the ghost profile is never repaired: the membership value is unchanged so no member event is sent, and when one is sent it copies the stale cached displayname straight back.
Sync joined ghosts whose name differs from the room's current member state, take the displayname and avatar from the ghost when rewriting an existing member event, and skip the invite downgrade for members who are already joined.