bridgev2/provisioning: support challenges - #529
Draft
slice wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Networks can often put clients into a state where an interactive flow is required to resolve some condition that unblocks further use.
Define a new
ChallengeProvidingNetworkAPIinterface that lets connectors model the flow throughLoginProcess, which we're exploiting here to provide a sort of bridge-driven UI. Additionally, we useProvLoginto reuse its state tracking.Clients msut contain some logic to hit
/v3/login/challengewhen they observe that the bridge is inBAD_CREDENTIALS. Right now this is undefined. However, a valid approach could be checking it every time a reconnect is needed.