Fix garbled memory_limit warning in CLI install output example - #926
Conversation
Update the sample mautic:install output to match the corrected CLI warning from mautic/mautic PR #17100: strip the <strong> HTML tags and replace the unfilled %min_memory_limit% placeholder with 512M.
| 0 - Checking installation requirements... | ||
| Missing optional settings: | ||
| - [0] The <strong>memory_limit</strong> setting in your PHP configuration is lower than the suggested minimum limit of %min_memory_limit%. Mautic can have performance issues with large datasets without sufficient memory. | ||
| - [0] The memory_limit setting in your PHP configuration is lower than the suggested minimum limit of 512M. Mautic can have performance issues with large datasets without sufficient memory. |
There was a problem hiding this comment.
CheckStep::RECOMMENDED_MEMORY_LIMIT is '512M', the minimum memory_limit value the CLI installer warning now substitutes in place of the %min_memory_limit% placeholder.
| 0 - Checking installation requirements... | ||
| Missing optional settings: | ||
| - [0] The <strong>memory_limit</strong> setting in your PHP configuration is lower than the suggested minimum limit of %min_memory_limit%. Mautic can have performance issues with large datasets without sufficient memory. | ||
| - [0] The memory_limit setting in your PHP configuration is lower than the suggested minimum limit of 512M. Mautic can have performance issues with large datasets without sufficient memory. |
There was a problem hiding this comment.
InstallService::getTranslationParameters() maps the mautic.install.memory.limit translation key to ['%min_memory_limit%' => CheckStep::RECOMMENDED_MEMORY_LIMIT], so the CLI output substitutes 512M for the placeholder (PR mautic/mautic#17100, fixes #17088; open at time of verification).
| 0 - Checking installation requirements... | ||
| Missing optional settings: | ||
| - [0] The <strong>memory_limit</strong> setting in your PHP configuration is lower than the suggested minimum limit of %min_memory_limit%. Mautic can have performance issues with large datasets without sufficient memory. | ||
| - [0] The memory_limit setting in your PHP configuration is lower than the suggested minimum limit of 512M. Mautic can have performance issues with large datasets without sufficient memory. |
There was a problem hiding this comment.
InstallCommand::handleInstallerErrors() applies strip_tags() to each optional-setting message before writing it to the CLI, so HTML tags like no longer appear in the terminal output (PR mautic/mautic#17100, fixes #17088; open at time of verification).
| 0 - Checking installation requirements... | ||
| Missing optional settings: | ||
| - [0] The <strong>memory_limit</strong> setting in your PHP configuration is lower than the suggested minimum limit of %min_memory_limit%. Mautic can have performance issues with large datasets without sufficient memory. | ||
| - [0] The memory_limit setting in your PHP configuration is lower than the suggested minimum limit of 512M. Mautic can have performance issues with large datasets without sufficient memory. |
There was a problem hiding this comment.
Source translation string mautic.install.memory.limit: "The memory_limit setting in your PHP configuration is lower than the suggested minimum limit of %min_memory_limit%. Mautic can have performance issues with large datasets without sufficient memory." — matches the rest of the doc's example sentence once tags are stripped and the placeholder is substituted.
1 participant
Open in Promptless
The installation guide's sample
mautic:installterminal output reproduced a broken low-memory warning — it showed raw<strong>HTML tags and an unfilled%min_memory_limit%placeholder. Mautic PR #17100 fixes the CLI installer so this warning now prints as clean plain text with the placeholder resolved. This updates the documented example to match: the HTML tags are removed and%min_memory_limit%becomes512M.Trigger Events