Skip to content

Convert to Swift 4.2 - #199

Open
benlachman wants to merge 9 commits into
matthewpalmer:masterfrom
nicemohawk:swift-4.2
Open

Convert to Swift 4.2#199
benlachman wants to merge 9 commits into
matthewpalmer:masterfrom
nicemohawk:swift-4.2

Conversation

@benlachman

Copy link
Copy Markdown

Simple conversion from 4.0 to 4.2 along with project file updates and the removal of unused pod config files referenced from Xcode.

@tc

tc commented Dec 16, 2018

Copy link
Copy Markdown

@benlachman looks like the CI tests are failing:

❌  “Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.

@DmitryPR

Copy link
Copy Markdown

What is the reason Travis is failing? Can we get this fixed?

@gcharita

Copy link
Copy Markdown

You probably need to change osx_image to xcode10.1 in .travis.yml file, to see if this PR actually passes the tests.

@DmitryPR DmitryPR mentioned this pull request Jan 17, 2019
@grifas

grifas commented Feb 4, 2019

Copy link
Copy Markdown

Any news ?

@DmitryPR

DmitryPR commented Feb 4, 2019

Copy link
Copy Markdown

Created a separate PR with this fix and travis fix not sure who can review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants