Operator: Fix error output and prevent silent failures in next command - #307
Operator: Fix error output and prevent silent failures in next command#307matta wants to merge 1 commit into
next command#307Conversation
…t` command
- Change error formatting in `main.rs` to use `{}` with `error: ` prefix instead of verbose `{:?}` stack traces, making output parseable for agents and clean for humans.
- Reorder `tasks.is_empty()` check in `next` command to properly return `NotFoundError` and exit code 1 even when `--json` is provided, preventing silent failures.
- Update relevant integration tests in `cli_check.rs` and `cli_json.rs` to expect the new formatting and behavior.
Co-authored-by: matta <37314+matta@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Merging to
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience and reliability of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request standardizes error output and exit codes across the pebble CLI. It updates the operator.md documentation to reflect new guidelines for error formatting and non-zero exit codes for search commands that find no results. Specifically, the run_next command now returns a NotFoundError with a non-zero exit code if no tasks are found, even when --json is used, addressing a silent failure anti-pattern. Error handling in main.rs is refactored to consistently print error: <message> to stderr, removing verbose debug output. Corresponding integration tests have been updated to assert against the new standardized error messages and the expected JSON output for the next command.
Addresses two key UX issues:
pebble next --jsonreturned{"tasks":[]}and exited with code 0 when no tasks were found. This violated the rule to consistently use exit code > 0 for missing items to prevent silent failures in automated scripts.main.rsused theDebugformatter ({:?}), which dumped noisy stack traces with ANSI color escapes directly tostderr. This made error parsing difficult and intimidating. It has been replaced with the standardDisplayformatter ({}) prefixed witherror:.PR created automatically by Jules for task 7910046922314857452 started by @matta