Skip to content

🎨 Palette: TaskRow UI polish and a11y focus states - #660

Open
matta wants to merge 1 commit into
mainfrom
palette-task-row-icon-a11y-6650459406755969426
Open

🎨 Palette: TaskRow UI polish and a11y focus states#660
matta wants to merge 1 commit into
mainfrom
palette-task-row-icon-a11y-6650459406755969426

Conversation

@matta

@matta matta commented Mar 13, 2026

Copy link
Copy Markdown
Owner

💡 What: Converted the 'Delete' button in the TaskRow to an icon button variant and added :focus-visible outline styles to the task title span for keyboard navigation.
🎯 Why: The Destructive button variant with its background text styling was overly bulky next to the clean SVG icons. Changing to an Icon button streamlines the UI. Adding focus-visible ensures keyboard users can clearly see which task title is currently focused.
📸 Before/After: See generated Playwright screenshots.
♿ Accessibility: Improved keyboard navigation feedback significantly with outline styles for the span element functioning as a button.


PR created automatically by Jules for task 6650459406755969426 started by @matta

- Change the `Delete` button in `TaskRow` to an icon button (using `ButtonVariant::Icon`), aligning with other adjacent icon buttons like 'Add Subtask'.
- Add `:focus-visible` styling to `.title_base` to provide a clear visible outline when navigating task titles with the keyboard.

Co-authored-by: matta <37314+matta@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@trunk-io

trunk-io Bot commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the user interface and improves accessibility within the TaskRow component. It addresses visual clutter by updating a button's appearance and significantly enhances keyboard navigation by providing clear focus indicators for interactive elements.

Highlights

  • UI Polish: The 'Delete' button in the TaskRow component has been converted from a 'Destructive' variant to an 'Icon' variant, streamlining the user interface.
  • Accessibility Improvement: Added ':focus-visible' outline styles to the task title span, enhancing keyboard navigation feedback for users.
Changelog
  • crates/tasklens-ui/src/app_components/task_row.css
    • Added ':focus-visible' styles to the '.title_base' class, including an outline, border-radius, and outline-offset.
  • crates/tasklens-ui/src/app_components/task_row.rs
    • Changed the 'variant' of the 'Delete' button from 'ButtonVariant::Destructive' to 'ButtonVariant::Icon'.
    • Updated the 'title' attribute of the 'Delete' button from "Delete" to "Delete task".
Activity
  • No human activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refines the TaskRow component by changing the 'Delete' button from a text-based 'Destructive' variant to an Icon variant, and updates its tooltip text for clarity. It also improves keyboard accessibility by adding a :focus-visible outline style to the task title span. The changes are focused and correctly implement the described UI polish and accessibility enhancements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant