Skip to content

Drop unused YAML PHP extension as optional dependency #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ngandrass wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −16
Open

Drop unused YAML PHP extension as optional dependency #1802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd30d7d
Fix missing PHP_EXTENSIONS closing tag in environment.xml
ngandrass Jul 13, 2026
abaf1a1
Remove old yaml PHP extension from environment in favor or symfony/yaml
ngandrass Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions api/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ FROM php:8.4.5-apache-bookworm AS base
#Install required php extensions
RUN apt-get update && \
apt-get -y install libicu-dev libyaml-dev libzip-dev zip && \
pecl install yaml && \
docker-php-ext-configure intl && \
docker-php-ext-enable yaml && \
docker-php-ext-install intl zip && \
a2enmod rewrite && a2enmod actions

Expand Down
2 changes: 0 additions & 2 deletions api/docker/DockerfileDemo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ FROM php:8.4.5-apache-bookworm AS base
#Install required php extensions
RUN apt-get update && \
apt-get -y install libicu-dev libyaml-dev libzip-dev zip && \
pecl install yaml && \
docker-php-ext-configure intl && \
docker-php-ext-enable yaml && \
docker-php-ext-install intl zip && \
a2enmod rewrite && a2enmod actions

Expand Down
18 changes: 7 additions & 11 deletions environment.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,13 @@
<COMPATIBILITY_MATRIX>
<PLUGIN name="qtype_stack">
<PHP version="8.1.0" level="required">
<PHP_EXTENSIONS>
<PHP_EXTENSION name="mbstring" level="required">
<FEEDBACK>
<ON_ERROR message="mbstringrequired" plugin="qtype_stack" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="yaml" level="optional">
<FEEDBACK>
<ON_CHECK message="yamlrecommended" plugin="qtype_stack" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSIONS>
<PHP_EXTENSION name="mbstring" level="required">
<FEEDBACK>
<ON_ERROR message="mbstringrequired" plugin="qtype_stack" />
</FEEDBACK>
</PHP_EXTENSION>
</PHP_EXTENSIONS>
</PHP>
</PLUGIN>
</COMPATIBILITY_MATRIX>
1 change: 0 additions & 1 deletion lang/en/qtype_stack.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
$string['cachedef_librarycache'] = 'STACK question library renders and file structure';

$string['mbstringrequired'] = 'Installing the MBSTRING library is required for STACK.';
$string['yamlrecommended'] = 'Installing the YAML library is recommended for STACK.';

// General strings.
$string['errors'] = 'Errors';
Expand Down
Loading