P1D.4: unified COMTRADE cursors, realtime scrub and SIGRA-style harmonics - #300
P1D.4: unified COMTRADE cursors, realtime scrub and SIGRA-style harmonics#300masarray wants to merge 52 commits into
Conversation
Exact-head validation — P1D.3 first sliceValidated head: All qualification gates are green on this exact head:
Field-retention policy: keep this PR draft / unmerged until the same protection COMTRADE record is re-tested for cursor drag, left/right pan, dense digital-event readability, and the new Harmonics view. Expected field differences vs P1D.2D:
|
|
Exact-head qualification is complete for Green gates:
Field-test package from installer run #808:
PR remains draft intentionally until this exact build is exercised against the real protection COMTRADE field record. Focus the field check on C1/C2 drag smoothness, pan responsiveness, digital transition readability/snap, Phasor display, and Harmonics display. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8870d2773
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| else | ||
| { | ||
| cursorReference = TryResolveAnalysisCursorFrame(preferredCursor, out var cursorFrame); | ||
| referenceFrame = cursorReference ? cursorFrame : ResolveAnalysisReferenceFrame(preferredCursor); | ||
| referenceName = cursorReference ? CursorName(preferredCursor) : "visible center"; |
There was a problem hiding this comment.
Defer harmonics until the H cursor can be resolved
If Harmonics is selected while the initial disturbance load is still running, _harmonicCursorMilliseconds is initialized but the reference timestamp arrays are not yet available, so this fallback silently analyzes C1 or the record center instead of H. The load completion only raises a navigation event, whose shell handler synchronizes the ruler without refreshing harmonics, leaving a result that can remain associated with the wrong frame while the UI presents H as its reference. Avoid calculating until H resolves, or refresh harmonics when the disturbance reference arrays become available.
Useful? React with 👍 / 👎.
Field-driven P1D.4 continuation of the COMTRADE investigation workstation. Keep this PR unmerged until the same field COMTRADE record used for the SIGRA comparison is re-tested.
P1D.4 fixes now in the branch:
Exact-head qualification:
de302869f6437c8eb96e1c1303e57e0d5de1c71c— 4/4 green.Field-test focus against SIGRA / ligne_1:
Do not merge until field comparison is accepted.