Fixed upside-down camera image on Linux - #628
Open
sofian wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CameraSurface::onVideoFrameChanged()kept a Linux-only transform (horizontal mirror + 180° rotation, net a vertical flip) inherited from a pre-Qt6 OpenGL orientation workaround. The exact same transform was already identified and removed on macOS in f1e51b4 ("Fix upside-down camera image on macOS") — Qt 6'sQVideoFrame/QVideoSinkdeliver upright, top-left-origin frames on every platform (same convention the video-file path already relies on unmodified), so the flip only made the image upside-down. That commit left Linux's branch untouched out of caution, with a comment inviting a follow-up ("adjust if cameras look flipped").Removed the now-platform-wide special case; all platforms use the frame as-is.
Test plan
qmake6 mapmap.pro && makebuilds cleantests/suite builds and all tests passCameraSurface::onVideoFrameChanged()in a standalone harness and fed it a synthetic top-red/bottom-blueQVideoFramedirectly viaQVideoSink::setVideoFrame()(bypassing camera hardware/libcamera entirely, which doesn't enumerate the v4l2loopback device available in this environment). Before the fix: red/blue came out swapped (upside down). After the fix: correct orientation.