Conversation
mana-byte
left a comment
mana-byte
left a comment
There was a problem hiding this comment.
This is a test message
Review has been Auto generated using manabyte/nixpkgs-review-quality
| versionCheckHook, | ||
| writableTmpDirAsHomeHook, | ||
| }: | ||
| python3Packages.buildPythonApplication rec { |
There was a problem hiding this comment.
Replace 'rec' with 'finalAttrs' to use a more modern and efficient way to inherit attributes from stdenv in Nix.
| python3Packages.buildPythonApplication rec { | |
| python3Packages.buildPythonApplication (finalAttrs { |
| meta = { | ||
| description = "YOLO is an amazing and powerful tool that lets you easily train models for all your computer vision tasks."; | ||
| homepage = "https://github.com/mistralai/mistral-vibe"; | ||
| changelog = "https://github.com/mistralai/mistral-vibe/blob/${version}/CHANGELOG.md"; |
There was a problem hiding this comment.
Update the reference to 'version' to use 'finalAttrs.version' to maintain recursiveness while using finalAttrs.
| changelog = "https://github.com/mistralai/mistral-vibe/blob/${version}/CHANGELOG.md"; | |
| changelog = "https://github.com/mistralai/mistral-vibe/blob/${finalAttrs.version}/CHANGELOG.md"; |
| ]; | ||
|
|
||
| meta = { | ||
| description = "YOLO is an amazing and powerful tool that lets you easily train models for all your computer vision tasks."; |
There was a problem hiding this comment.
Meta descriptions must be a single capitalized sentence that avoids starting with articles or the package name, omits punctuation, provides factual information, and excludes subjective language.
| description = "YOLO is an amazing and powerful tool that lets you easily train models for all your computer vision tasks."; | |
| description = "Tool for training models for computer vision tasks"; |
| version = "2.4.2"; | ||
| pyproject = true; | ||
|
|
||
| src = fetchFromGitHub { |
There was a problem hiding this comment.
It is generally better to use tag than rev in fetchFromGitHub function if the repo has an up to date tag.
| src = fetchFromGitHub { | |
| src = fetchFromGitHub { | |
| owner = "mistralai"; | |
| repo = "mistral-vibe"; | |
| tag = "v${finalAttrs.version}"; | |
| hash = "sha256-r/9kMhkoLfj9oEifFun/bpIQYEouqm9YEiWZVk07+S8="; | |
| }; |
| hash = "sha256-r/9kMhkoLfj9oEifFun/bpIQYEouqm9YEiWZVk07+S8="; | ||
| }; | ||
|
|
||
| nativeBuildInputs = with python3Packages; [ |
There was a problem hiding this comment.
According to modern conventions, use 'build-system' instead of 'nativeBuildInputs'.
| nativeBuildInputs = with python3Packages; [ | |
| build-system = with python3Packages; [ |
| "pydantic-settings" | ||
| "zstandard" | ||
| ]; | ||
| propagatedBuildInputs = with python3Packages; [ |
There was a problem hiding this comment.
According to modern conventions, use 'dependencies' instead of 'propagatedBuildInputs'.
| propagatedBuildInputs = with python3Packages; [ | |
| dependencies = with python3Packages; [ |
| ]; | ||
| versionCheckKeepEnvironment = ["HOME"]; | ||
|
|
||
| disabledTests = lib.optionals stdenv.hostPlatform.isDarwin [ |
There was a problem hiding this comment.
Add a comment explaining why the tests are disabled.
| disabledTests = lib.optionals stdenv.hostPlatform.isDarwin [ | |
| disabledTests = lib.optionals stdenv.hostPlatform.isDarwin [ | |
| # Tests disabled on Darwin due to platform-specific issues |
| "test_watcher_toggle_flow_off_on_off" | ||
| ]; | ||
|
|
||
| disabledTestPaths = [ |
There was a problem hiding this comment.
Add a comment explaining why the test paths are disabled.
| disabledTestPaths = [ | |
| disabledTestPaths = [ | |
| # Tests disabled due to specific issues |
1 participant
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.