Skip to content

pls_bad_pr - #1

Open
mana-byte wants to merge 1 commit into
masterfrom
test/place_holder_pr
Open

pls_bad_pr#1
mana-byte wants to merge 1 commit into
masterfrom
test/place_holder_pr

Conversation

@mana-byte

@mana-byte mana-byte commented Mar 15, 2026

Copy link
Copy Markdown
Owner

Things done

This PR is a test pr for https://github.com/mana-byte/nixpkgs-review-quality

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

mana-byte

This comment was marked as outdated.

Sign in to view

mana-byte

This comment was marked as outdated.

Sign in to view

mana-byte

This comment was marked as outdated.

Sign in to view

mana-byte

This comment was marked as outdated.

Sign in to view

mana-byte

This comment was marked as outdated.

Sign in to view

mana-byte

This comment was marked as outdated.

Sign in to view

mana-byte

This comment was marked as outdated.

Sign in to view

mana-byte

This comment was marked as outdated.

Sign in to view

mana-byte

This comment was marked as outdated.

Sign in to view

mana-byte
mana-byte commented Mar 16, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

Comment thread pkgs/development/python-modules/pr_test/package.nix
pytestCheckHook,
}:

buildPythonPackage rec {

@mana-byte mana-byte Mar 16, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'rec' with 'finalAttrs' to use a more modern and efficient way to inherit attributes from stdenv in Nix.

Suggested change
buildPythonPackage rec {
buildPythonPackage (finalAttrs: {

Comment thread pkgs/development/python-modules/pr_test/package.nix
src = fetchFromGitHub {
owner = "ultralytics";
repo = "ultralytics";
tag = "v${version}";

@mana-byte mana-byte Mar 16, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'version' to use 'finalAttrs.version' to maintain recursiveness while using finalAttrs.

Suggested change
tag = "v${version}";
tag = "v${finalAttrs.version}";

Comment thread pkgs/development/python-modules/pr_test/package.nix

meta = {
homepage = "https://github.com/ultralytics/ultralytics";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";

@mana-byte mana-byte Mar 16, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'src.tag' to use 'finalAttrs.src.tag' to maintain recursiveness while using finalAttrs.

Suggested change
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${finalAttrs.src.tag}";

Comment thread pkgs/development/python-modules/pr_test/package.nix
hash = "sha256-KyTqO5jjYXnw5xwKlvwnY99SE0zkLaz8Ck6hKb7non8=";
};

nativeBuildInputs = [ setuptools ];

@mana-byte mana-byte Mar 16, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'nativeBuildInputs' with 'build-system' to follow modern conventions for Python packages.

Suggested change
nativeBuildInputs = [ setuptools ];
build-system = [ setuptools ];

Comment thread pkgs/development/python-modules/pr_test/package.nix
"numpy"
];

propagatedBuildInputs = [

@mana-byte mana-byte Mar 16, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'propagatedBuildInputs' with 'dependencies' to follow modern conventions for Python packages.

Suggested change
propagatedBuildInputs = [
dependencies = [

mana-byte
mana-byte commented Mar 17, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

Comment thread pkgs/development/python-modules/pr_test/package.nix
pytestCheckHook,
}:

buildPythonPackage rec {

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'rec' with 'finalAttrs' to use a more modern and efficient way to inherit attributes from stdenv in Nix.

Suggested change
buildPythonPackage rec {
buildPythonPackage (finalAttrs: {

Comment thread pkgs/development/python-modules/pr_test/package.nix
src = fetchFromGitHub {
owner = "ultralytics";
repo = "ultralytics";
tag = "v${version}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'version' to use 'finalAttrs.version' to maintain recursiveness while using finalAttrs.

Suggested change
tag = "v${version}";
tag = "v${finalAttrs.version}";

Comment thread pkgs/development/python-modules/pr_test/package.nix

meta = {
homepage = "https://github.com/ultralytics/ultralytics";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'src.tag' to use 'finalAttrs.src.tag' to maintain recursiveness while using finalAttrs.

Suggested change
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${finalAttrs.src.tag}";

Comment thread pkgs/development/python-modules/pr_test/package.nix
hash = "sha256-KyTqO5jjYXnw5xwKlvwnY99SE0zkLaz8Ck6hKb7non8=";
};

nativeBuildInputs = [ setuptools ];

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'nativeBuildInputs' with 'build-system' to follow modern conventions for Python packages.

Suggested change
nativeBuildInputs = [ setuptools ];
build-system = [ setuptools ];

Comment thread pkgs/development/python-modules/pr_test/package.nix
"numpy"
];

propagatedBuildInputs = [

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'propagatedBuildInputs' with 'dependencies' to follow modern conventions for Python packages.

Suggested change
propagatedBuildInputs = [
dependencies = [

mana-byte
mana-byte commented Mar 17, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

Comment thread pkgs/development/python-modules/pr_test/package.nix
pytestCheckHook,
}:

buildPythonPackage rec {

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'rec' with 'finalAttrs' to use a more modern and efficient way to inherit attributes from stdenv in Nix.

Suggested change
buildPythonPackage rec {
buildPythonPackage (finalAttrs: {

Comment thread pkgs/development/python-modules/pr_test/package.nix
src = fetchFromGitHub {
owner = "ultralytics";
repo = "ultralytics";
tag = "v${version}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'version' to use 'finalAttrs.version' to maintain recursiveness while using finalAttrs.

Suggested change
tag = "v${version}";
tag = "v${finalAttrs.version}";

Comment thread pkgs/development/python-modules/pr_test/package.nix

meta = {
homepage = "https://github.com/ultralytics/ultralytics";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'src.tag' to use 'finalAttrs.src.tag' to maintain recursiveness while using finalAttrs.

Suggested change
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${finalAttrs.src.tag}";

Comment thread pkgs/development/python-modules/pr_test/package.nix
hash = "sha256-KyTqO5jjYXnw5xwKlvwnY99SE0zkLaz8Ck6hKb7non8=";
};

nativeBuildInputs = [ setuptools ];

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'nativeBuildInputs' with 'build-system' to follow modern conventions for Python packages.

Suggested change
nativeBuildInputs = [ setuptools ];
build-system = [ setuptools ];

Comment thread pkgs/development/python-modules/pr_test/package.nix
"numpy"
];

propagatedBuildInputs = [

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'propagatedBuildInputs' with 'dependencies' to follow modern conventions for Python packages.

Suggested change
propagatedBuildInputs = [
dependencies = [

mana-byte
mana-byte commented Mar 17, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

Comment thread pkgs/development/python-modules/pr_test/package.nix
pytestCheckHook,
}:

buildPythonPackage rec {

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'rec' with 'finalAttrs' to use a more modern and efficient way to inherit attributes from stdenv in Nix.

Suggested change
buildPythonPackage rec {
buildPythonPackage (finalAttrs: {

Comment thread pkgs/development/python-modules/pr_test/package.nix
src = fetchFromGitHub {
owner = "ultralytics";
repo = "ultralytics";
tag = "v${version}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'version' to use 'finalAttrs.version' to maintain recursiveness while using finalAttrs.

Suggested change
tag = "v${version}";
tag = "v${finalAttrs.version}";

Comment thread pkgs/development/python-modules/pr_test/package.nix

meta = {
homepage = "https://github.com/ultralytics/ultralytics";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'src.tag' to use 'finalAttrs.src.tag' to maintain recursiveness while using finalAttrs.

Suggested change
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${finalAttrs.src.tag}";

Comment thread pkgs/development/python-modules/pr_test/package.nix
hash = "sha256-KyTqO5jjYXnw5xwKlvwnY99SE0zkLaz8Ck6hKb7non8=";
};

nativeBuildInputs = [ setuptools ];

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'nativeBuildInputs' with 'build-system' to follow modern conventions for Python packages.

Suggested change
nativeBuildInputs = [ setuptools ];
build-system = [ setuptools ];

Comment thread pkgs/development/python-modules/pr_test/package.nix
"numpy"
];

propagatedBuildInputs = [

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'propagatedBuildInputs' with 'dependencies' to follow modern conventions for Python packages.

Suggested change
propagatedBuildInputs = [
dependencies = [

mana-byte
mana-byte commented Mar 17, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

Comment thread pkgs/development/python-modules/pr_test/package.nix
pytestCheckHook,
}:

buildPythonPackage rec {

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'rec' with 'finalAttrs' to use a more modern and efficient way to inherit attributes from stdenv in Nix.

Suggested change
buildPythonPackage rec {
buildPythonPackage (finalAttrs: {

Comment thread pkgs/development/python-modules/pr_test/package.nix
src = fetchFromGitHub {
owner = "ultralytics";
repo = "ultralytics";
tag = "v${version}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'version' to use 'finalAttrs.version' to maintain recursiveness while using finalAttrs.

Suggested change
tag = "v${version}";
tag = "v${finalAttrs.version}";

Comment thread pkgs/development/python-modules/pr_test/package.nix

meta = {
homepage = "https://github.com/ultralytics/ultralytics";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'src.tag' to use 'finalAttrs.src.tag' to maintain recursiveness while using finalAttrs.

Suggested change
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${finalAttrs.src.tag}";

Comment thread pkgs/development/python-modules/pr_test/package.nix
hash = "sha256-KyTqO5jjYXnw5xwKlvwnY99SE0zkLaz8Ck6hKb7non8=";
};

nativeBuildInputs = [ setuptools ];

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'nativeBuildInputs' with 'build-system' to follow modern conventions for Python packages.

Suggested change
nativeBuildInputs = [ setuptools ];
build-system = [ setuptools ];

Comment thread pkgs/development/python-modules/pr_test/package.nix
"numpy"
];

propagatedBuildInputs = [

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'propagatedBuildInputs' with 'dependencies' to follow modern conventions for Python packages.

Suggested change
propagatedBuildInputs = [
dependencies = [

mana-byte
mana-byte commented Mar 17, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

Comment thread pkgs/development/python-modules/pr_test/package.nix
pytestCheckHook,
}:

buildPythonPackage rec {

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'rec' with 'finalAttrs' to use a more modern and efficient way to inherit attributes from stdenv in Nix.

Suggested change
buildPythonPackage rec {
buildPythonPackage (finalAttrs: {

Comment thread pkgs/development/python-modules/pr_test/package.nix
src = fetchFromGitHub {
owner = "ultralytics";
repo = "ultralytics";
tag = "v${version}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'version' to use 'finalAttrs.version' to maintain recursiveness while using finalAttrs.

Suggested change
tag = "v${version}";
tag = "v${finalAttrs.version}";

Comment thread pkgs/development/python-modules/pr_test/package.nix

meta = {
homepage = "https://github.com/ultralytics/ultralytics";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'src.tag' to use 'finalAttrs.src.tag' to maintain recursiveness while using finalAttrs.

Suggested change
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${finalAttrs.src.tag}";

Comment thread pkgs/development/python-modules/pr_test/package.nix
hash = "sha256-KyTqO5jjYXnw5xwKlvwnY99SE0zkLaz8Ck6hKb7non8=";
};

nativeBuildInputs = [ setuptools ];

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'nativeBuildInputs' with 'build-system' to follow modern conventions for Python packages.

Suggested change
nativeBuildInputs = [ setuptools ];
build-system = [ setuptools ];

Comment thread pkgs/development/python-modules/pr_test/package.nix
"numpy"
];

propagatedBuildInputs = [

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'propagatedBuildInputs' with 'dependencies' to follow modern conventions for Python packages.

Suggested change
propagatedBuildInputs = [
dependencies = [

mana-byte
mana-byte commented Mar 17, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

Comment thread pkgs/development/python-modules/pr_test/package.nix
pytestCheckHook,
}:

buildPythonPackage rec {

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'rec' with 'finalAttrs' to use a more modern and efficient way to inherit attributes from stdenv in Nix.

Suggested change
buildPythonPackage rec {
buildPythonPackage (finalAttrs: {

Comment thread pkgs/development/python-modules/pr_test/package.nix
src = fetchFromGitHub {
owner = "ultralytics";
repo = "ultralytics";
tag = "v${version}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'version' to use 'finalAttrs.version' to maintain recursiveness while using finalAttrs.

Suggested change
tag = "v${version}";
tag = "v${finalAttrs.version}";

Comment thread pkgs/development/python-modules/pr_test/package.nix

meta = {
homepage = "https://github.com/ultralytics/ultralytics";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'src.tag' to use 'finalAttrs.src.tag' to maintain recursiveness while using finalAttrs.

Suggested change
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${finalAttrs.src.tag}";

Comment thread pkgs/development/python-modules/pr_test/package.nix
hash = "sha256-KyTqO5jjYXnw5xwKlvwnY99SE0zkLaz8Ck6hKb7non8=";
};

nativeBuildInputs = [ setuptools ];

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'nativeBuildInputs' with 'build-system' to follow modern conventions for Python packages.

Suggested change
nativeBuildInputs = [ setuptools ];
build-system = [ setuptools ];

Comment thread pkgs/development/python-modules/pr_test/package.nix
"numpy"
];

propagatedBuildInputs = [

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'propagatedBuildInputs' with 'dependencies' to follow modern conventions for Python packages.

Suggested change
propagatedBuildInputs = [
dependencies = [

mana-byte
mana-byte commented Mar 17, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

Comment thread pkgs/development/python-modules/pr_test/package.nix
pytestCheckHook,
}:

buildPythonPackage rec {

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'rec' with 'finalAttrs' to use a more modern and efficient way to inherit attributes from stdenv in Nix.

Suggested change
buildPythonPackage rec {
buildPythonPackage (finalAttrs: {

Comment thread pkgs/development/python-modules/pr_test/package.nix
src = fetchFromGitHub {
owner = "ultralytics";
repo = "ultralytics";
tag = "v${version}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'version' to use 'finalAttrs.version' to maintain recursiveness while using finalAttrs.

Suggested change
tag = "v${version}";
tag = "v${finalAttrs.version}";

Comment thread pkgs/development/python-modules/pr_test/package.nix

meta = {
homepage = "https://github.com/ultralytics/ultralytics";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'src.tag' to use 'finalAttrs.src.tag' to maintain recursiveness while using finalAttrs.

Suggested change
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${finalAttrs.src.tag}";

Comment thread pkgs/development/python-modules/pr_test/package.nix
hash = "sha256-KyTqO5jjYXnw5xwKlvwnY99SE0zkLaz8Ck6hKb7non8=";
};

nativeBuildInputs = [ setuptools ];

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'nativeBuildInputs' with 'build-system' to follow modern conventions for Python packages.

Suggested change
nativeBuildInputs = [ setuptools ];
build-system = [ setuptools ];

Comment thread pkgs/development/python-modules/pr_test/package.nix
"numpy"
];

propagatedBuildInputs = [

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'propagatedBuildInputs' with 'dependencies' to follow modern conventions for Python packages.

Suggested change
propagatedBuildInputs = [
dependencies = [

mana-byte
mana-byte commented Mar 17, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

Comment thread pkgs/development/python-modules/pr_test/package.nix
pytestCheckHook,
}:

buildPythonPackage rec {

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'rec' with 'finalAttrs' to use a more modern and efficient way to inherit attributes from stdenv in Nix.

Suggested change
buildPythonPackage rec {
buildPythonPackage (finalAttrs: {

Comment thread pkgs/development/python-modules/pr_test/package.nix
src = fetchFromGitHub {
owner = "ultralytics";
repo = "ultralytics";
tag = "v${version}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'version' to use 'finalAttrs.version' to maintain recursiveness while using finalAttrs.

Suggested change
tag = "v${version}";
tag = "v${finalAttrs.version}";

Comment thread pkgs/development/python-modules/pr_test/package.nix

meta = {
homepage = "https://github.com/ultralytics/ultralytics";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'src.tag' to use 'finalAttrs.src.tag' to maintain recursiveness while using finalAttrs.

Suggested change
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${finalAttrs.src.tag}";

Comment thread pkgs/development/python-modules/pr_test/package.nix
hash = "sha256-KyTqO5jjYXnw5xwKlvwnY99SE0zkLaz8Ck6hKb7non8=";
};

nativeBuildInputs = [ setuptools ];

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'nativeBuildInputs' with 'build-system' to follow modern conventions for Python packages.

Suggested change
nativeBuildInputs = [ setuptools ];
build-system = [ setuptools ];

Comment thread pkgs/development/python-modules/pr_test/package.nix
"numpy"
];

propagatedBuildInputs = [

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'propagatedBuildInputs' with 'dependencies' to follow modern conventions for Python packages.

Suggested change
propagatedBuildInputs = [
dependencies = [

mana-byte
mana-byte commented Mar 17, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

Comment thread pkgs/development/python-modules/pr_test/package.nix
pytestCheckHook,
}:

buildPythonPackage rec {

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'rec' with 'finalAttrs' to use a more modern and efficient way to inherit attributes from stdenv in Nix.

Suggested change
buildPythonPackage rec {
buildPythonPackage (finalAttrs: {

Comment thread pkgs/development/python-modules/pr_test/package.nix
src = fetchFromGitHub {
owner = "ultralytics";
repo = "ultralytics";
tag = "v${version}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'version' to use 'finalAttrs.version' to maintain recursiveness while using finalAttrs.

Suggested change
tag = "v${version}";
tag = "v${finalAttrs.version}";

Comment thread pkgs/development/python-modules/pr_test/package.nix

meta = {
homepage = "https://github.com/ultralytics/ultralytics";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'src.tag' to use 'finalAttrs.src.tag' to maintain recursiveness while using finalAttrs.

Suggested change
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${finalAttrs.src.tag}";

Comment thread pkgs/development/python-modules/pr_test/package.nix
hash = "sha256-KyTqO5jjYXnw5xwKlvwnY99SE0zkLaz8Ck6hKb7non8=";
};

nativeBuildInputs = [ setuptools ];

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'nativeBuildInputs' with 'build-system' to follow modern conventions for Python packages.

Suggested change
nativeBuildInputs = [ setuptools ];
build-system = [ setuptools ];

Comment thread pkgs/development/python-modules/pr_test/package.nix
"numpy"
];

propagatedBuildInputs = [

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'propagatedBuildInputs' with 'dependencies' to follow modern conventions for Python packages.

Suggested change
propagatedBuildInputs = [
dependencies = [

mana-byte
mana-byte commented Mar 17, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

Comment thread pkgs/development/python-modules/pr_test/package.nix
pytestCheckHook,
}:

buildPythonPackage rec {

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'rec' with 'finalAttrs' to use a more modern and efficient way to inherit attributes from stdenv in Nix.

Suggested change
buildPythonPackage rec {
buildPythonPackage (finalAttrs: {

Comment thread pkgs/development/python-modules/pr_test/package.nix
src = fetchFromGitHub {
owner = "ultralytics";
repo = "ultralytics";
tag = "v${version}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'version' to use 'finalAttrs.version' to maintain recursiveness while using finalAttrs.

Suggested change
tag = "v${version}";
tag = "v${finalAttrs.version}";

Comment thread pkgs/development/python-modules/pr_test/package.nix

meta = {
homepage = "https://github.com/ultralytics/ultralytics";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'src.tag' to use 'finalAttrs.src.tag' to maintain recursiveness while using finalAttrs.

Suggested change
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${finalAttrs.src.tag}";

Comment thread pkgs/development/python-modules/pr_test/package.nix
hash = "sha256-KyTqO5jjYXnw5xwKlvwnY99SE0zkLaz8Ck6hKb7non8=";
};

nativeBuildInputs = [ setuptools ];

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'nativeBuildInputs' with 'build-system' to follow modern conventions for Python packages.

Suggested change
nativeBuildInputs = [ setuptools ];
build-system = [ setuptools ];

Comment thread pkgs/development/python-modules/pr_test/package.nix
"numpy"
];

propagatedBuildInputs = [

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'propagatedBuildInputs' with 'dependencies' to follow modern conventions for Python packages.

Suggested change
propagatedBuildInputs = [
dependencies = [

mana-byte
mana-byte commented Mar 17, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

Comment thread pkgs/development/python-modules/pr_test/package.nix
pytestCheckHook,
}:

buildPythonPackage rec {

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'rec' with 'finalAttrs' to use a more modern and efficient way to inherit attributes from stdenv in Nix.

Suggested change
buildPythonPackage rec {
buildPythonPackage (finalAttrs: {

Comment thread pkgs/development/python-modules/pr_test/package.nix
src = fetchFromGitHub {
owner = "ultralytics";
repo = "ultralytics";
tag = "v${version}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'version' to use 'finalAttrs.version' to maintain recursiveness while using finalAttrs.

Suggested change
tag = "v${version}";
tag = "v${finalAttrs.version}";

Comment thread pkgs/development/python-modules/pr_test/package.nix

meta = {
homepage = "https://github.com/ultralytics/ultralytics";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'src.tag' to use 'finalAttrs.src.tag' to maintain recursiveness while using finalAttrs.

Suggested change
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${finalAttrs.src.tag}";

Comment thread pkgs/development/python-modules/pr_test/package.nix
hash = "sha256-KyTqO5jjYXnw5xwKlvwnY99SE0zkLaz8Ck6hKb7non8=";
};

nativeBuildInputs = [ setuptools ];

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'nativeBuildInputs' with 'build-system' to follow modern conventions for Python packages.

Suggested change
nativeBuildInputs = [ setuptools ];
build-system = [ setuptools ];

Comment thread pkgs/development/python-modules/pr_test/package.nix
"numpy"
];

propagatedBuildInputs = [

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'propagatedBuildInputs' with 'dependencies' to follow modern conventions for Python packages.

Suggested change
propagatedBuildInputs = [
dependencies = [

mana-byte
mana-byte commented Mar 17, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

Comment thread pkgs/development/python-modules/pr_test/package.nix
pytestCheckHook,
}:

buildPythonPackage rec {

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'rec' with 'finalAttrs' to use a more modern and efficient way to inherit attributes from stdenv in Nix.

Suggested change
buildPythonPackage rec {
buildPythonPackage (finalAttrs: {

Comment thread pkgs/development/python-modules/pr_test/package.nix
src = fetchFromGitHub {
owner = "ultralytics";
repo = "ultralytics";
tag = "v${version}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'version' to use 'finalAttrs.version' to maintain recursiveness while using finalAttrs.

Suggested change
tag = "v${version}";
tag = "v${finalAttrs.version}";

Comment thread pkgs/development/python-modules/pr_test/package.nix

meta = {
homepage = "https://github.com/ultralytics/ultralytics";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'src.tag' to use 'finalAttrs.src.tag' to maintain recursiveness while using finalAttrs.

Suggested change
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${finalAttrs.src.tag}";

Comment thread pkgs/development/python-modules/pr_test/package.nix
hash = "sha256-KyTqO5jjYXnw5xwKlvwnY99SE0zkLaz8Ck6hKb7non8=";
};

nativeBuildInputs = [ setuptools ];

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'nativeBuildInputs' with 'build-system' to follow modern conventions for Python packages.

Suggested change
nativeBuildInputs = [ setuptools ];
build-system = [ setuptools ];

Comment thread pkgs/development/python-modules/pr_test/package.nix
"numpy"
];

propagatedBuildInputs = [

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'propagatedBuildInputs' with 'dependencies' to follow modern conventions for Python packages.

Suggested change
propagatedBuildInputs = [
dependencies = [

mana-byte
mana-byte commented Mar 17, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

Comment thread pkgs/development/python-modules/pr_test/package.nix
pytestCheckHook,
}:

buildPythonPackage rec {

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'rec' with 'finalAttrs' to use a more modern and efficient way to inherit attributes from stdenv in Nix.

Suggested change
buildPythonPackage rec {
buildPythonPackage (finalAttrs: {

Comment thread pkgs/development/python-modules/pr_test/package.nix
src = fetchFromGitHub {
owner = "ultralytics";
repo = "ultralytics";
tag = "v${version}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'version' to use 'finalAttrs.version' to maintain recursiveness while using finalAttrs.

Suggested change
tag = "v${version}";
tag = "v${finalAttrs.version}";

Comment thread pkgs/development/python-modules/pr_test/package.nix

meta = {
homepage = "https://github.com/ultralytics/ultralytics";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'src.tag' to use 'finalAttrs.src.tag' to maintain recursiveness while using finalAttrs.

Suggested change
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${finalAttrs.src.tag}";

Comment thread pkgs/development/python-modules/pr_test/package.nix
hash = "sha256-KyTqO5jjYXnw5xwKlvwnY99SE0zkLaz8Ck6hKb7non8=";
};

nativeBuildInputs = [ setuptools ];

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'nativeBuildInputs' with 'build-system' to follow modern conventions for Python packages.

Suggested change
nativeBuildInputs = [ setuptools ];
build-system = [ setuptools ];

Comment thread pkgs/development/python-modules/pr_test/package.nix
"numpy"
];

propagatedBuildInputs = [

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'propagatedBuildInputs' with 'dependencies' to follow modern conventions for Python packages.

Suggested change
propagatedBuildInputs = [
dependencies = [

mana-byte
mana-byte commented Mar 17, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

mana-byte
mana-byte commented Mar 17, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

mana-byte
mana-byte commented Mar 17, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

Comment thread pkgs/development/python-modules/pr_test/package.nix
pytestCheckHook,
}:

buildPythonPackage rec {

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'rec' with 'finalAttrs' to use a more modern and efficient way to inherit attributes from stdenv in Nix.

Suggested change
buildPythonPackage rec {
buildPythonPackage (finalAttrs: {

Comment thread pkgs/development/python-modules/pr_test/package.nix
src = fetchFromGitHub {
owner = "ultralytics";
repo = "ultralytics";
tag = "v${version}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'version' to use 'finalAttrs.version' to maintain recursiveness while using finalAttrs.

Suggested change
tag = "v${version}";
tag = "v${finalAttrs.version}";

Comment thread pkgs/development/python-modules/pr_test/package.nix

meta = {
homepage = "https://github.com/ultralytics/ultralytics";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'src.tag' to use 'finalAttrs.src.tag' to maintain recursiveness while using finalAttrs.

Suggested change
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${finalAttrs.src.tag}";

Comment thread pkgs/development/python-modules/pr_test/package.nix
hash = "sha256-KyTqO5jjYXnw5xwKlvwnY99SE0zkLaz8Ck6hKb7non8=";
};

nativeBuildInputs = [ setuptools ];

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'nativeBuildInputs' with 'build-system' to follow modern conventions for Python packages.

Suggested change
nativeBuildInputs = [ setuptools ];
build-system = [ setuptools ];

Comment thread pkgs/development/python-modules/pr_test/package.nix
"numpy"
];

propagatedBuildInputs = [

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'propagatedBuildInputs' with 'dependencies' to follow modern conventions for Python packages.

Suggested change
propagatedBuildInputs = [
dependencies = [

mana-byte
mana-byte commented Mar 17, 2026
View reviewed changes

@mana-byte mana-byte left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test review message

Review has been Auto generated using manabyte/nixpkgs-review-quality

Comment thread pkgs/development/python-modules/pr_test/package.nix
pytestCheckHook,
}:

buildPythonPackage rec {

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'rec' with 'finalAttrs' to use a more modern and efficient way to inherit attributes from stdenv in Nix.

Suggested change
buildPythonPackage rec {
buildPythonPackage (finalAttrs: {

Comment thread pkgs/development/python-modules/pr_test/package.nix
src = fetchFromGitHub {
owner = "ultralytics";
repo = "ultralytics";
tag = "v${version}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'version' to use 'finalAttrs.version' to maintain recursiveness while using finalAttrs.

Suggested change
tag = "v${version}";
tag = "v${finalAttrs.version}";

Comment thread pkgs/development/python-modules/pr_test/package.nix

meta = {
homepage = "https://github.com/ultralytics/ultralytics";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the reference to 'src.tag' to use 'finalAttrs.src.tag' to maintain recursiveness while using finalAttrs.

Suggested change
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${src.tag}";
changelog = "https://github.com/ultralytics/ultralytics/releases/tag/${finalAttrs.src.tag}";

Comment thread pkgs/development/python-modules/pr_test/package.nix
hash = "sha256-KyTqO5jjYXnw5xwKlvwnY99SE0zkLaz8Ck6hKb7non8=";
};

nativeBuildInputs = [ setuptools ];

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'nativeBuildInputs' with 'build-system' to follow modern conventions for Python packages.

Suggested change
nativeBuildInputs = [ setuptools ];
build-system = [ setuptools ];

Comment thread pkgs/development/python-modules/pr_test/package.nix
"numpy"
];

propagatedBuildInputs = [

@mana-byte mana-byte Mar 17, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'propagatedBuildInputs' with 'dependencies' to follow modern conventions for Python packages.

Suggested change
propagatedBuildInputs = [
dependencies = [

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mana-byte