Skip to content

Add ingress support - #3

Open
pando85 wants to merge 2 commits into
maildev:mainfrom
pando85:add-ingress
Open

Add ingress support#3
pando85 wants to merge 2 commits into
maildev:mainfrom
pando85:add-ingress

Conversation

@pando85

@pando85 pando85 commented Jul 14, 2021

Copy link
Copy Markdown

This code is based on Grafana helm chart.

@pando85
pando85 force-pushed the add-ingress branch 2 times, most recently from 398a6d9 to a108360 Compare July 14, 2021 09:52
@djfarrelly

Copy link
Copy Markdown
Member

Thanks for this @pando85, and apologies it sat so long. Ingress support is still a welcome addition — it wasn't superseded by the recent maildev 2.x work in #9 the way #4/#7 were.

That said, this PR now needs a rebase: the chart has since moved to maildev 2.x (appVersion 2.2.1) and the deployment/values were substantially reworked in #9 (maildev-0.2.0), so this branch conflicts with main. If you'd like to update it — rebasing onto current main with an ingress: block in values.yaml (guarded by ingress.enabled, following the common chart convention) — we'd be happy to review and merge. Otherwise we can pick it up as a follow-up. Leaving it open as a tracked feature request either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants