Enable TLS/HTTPS via Kubernetes Secret mounting - #11
Open
geekosphere-net wants to merge 2 commits into
Open
Conversation
Replace incomplete path-based HTTPS configuration with proper Kubernetes TLS Secret mounting. Users now reference an existing TLS Secret via https.secretName, and the chart automatically mounts files to container paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable TLS/HTTPS via Kubernetes Secret mounting
The previous
https.keyandhttps.certconfiguration was incomplet, as it passedfile paths as environment variables but provided no mechanism to mount actual
certificate files into the container, making HTTPS non-functional.
This change replaces it with a Kubernetes-native approach:
kubernetes.io/tlstype)https.secretNamein values/etc/ssl/certsand/etc/ssl/privateUpdated:
values.yaml: Replacehttps.key/certwithhttps.secretNameparameterdeployment.yaml: Add volume mounts for TLS secret files, update probes to use the correct scheme (HTTP/HTTPS) and endpoint (/api/healthz)NOTES.txt: Show https:// instead of http:// when HTTPS is enabledREADME.md: Document the new HTTPS setup process with examplesBREAKING CHANGE:
Users using
https.enabled=truemust migrate to the newhttps.secretNameapproach.See
READMEfor migration instructions.DEPENDENCY
This pull request assumes that the
maildevpull request 546 has been merged to correctly enable HTTPS in the container, and supports the new/api/healthzendpoints.