Make probe path configurable and document maildev 3.x opt-in - #10
Open
djfarrelly wants to merge 1 commit into
Open
Make probe path configurable and document maildev 3.x opt-in#10djfarrelly wants to merge 1 commit into
djfarrelly wants to merge 1 commit into
Conversation
maildev 3.x is a rewrite that removed the /healthz endpoint the liveness/readiness probes use, so a 3.x image would crashloop against the hardcoded path. Expose the probe path as `probePath` (default /healthz, unchanged for 2.x) so users can point it at "/" when running 3.x. Keep the stable 2.2.1 as the chart default (a published chart shouldn't default to a release candidate) and document how to opt into the 3.0.0-rc.1 image in the README and values.yaml. Chart version 0.2.0 -> 0.3.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Follow-up to the question of defaulting the chart to maildev 3.x. Investigation found:
--verbose,--auto-relay,--outgoing-secure, ports all work; noMAILDEV_HTTPS-style truthiness trap)./healthzendpoint. On3.0.0-rc.1,/healthz→ 404 and only/→ 200. Since the probes hardcode/healthz, a bareimage.tag: 3.0.0-rc.1would crashloop.Change
Keep 2.2.1 as the default appVersion.
Add a
probePathvalue (default/healthz, so 2.x behavior is unchanged) used by both the liveness and readiness probes.Document the 3.x opt-in in
values.yamland a new README section:Chart version
0.2.0 → 0.3.0(additive, backward-compatible).Verification
helm lint→ 0 failures.image: maildev/maildev:2.2.1, probespath: /healthz.--set image.tag=3.0.0-rc.1 --set probePath=/:image: maildev/maildev:3.0.0-rc.1, probespath: /.3.0.0-rc.1serves/→ 200 (and/healthz→ 404), 2.2.1 serves/healthz→ 200.🤖 Generated with Claude Code