Skip to content

Feat/mgs 5747#572

Open
a9a wants to merge 3 commits into
rocky-developfrom
feat/mgs-5747
Open

Feat/mgs 5747#572
a9a wants to merge 3 commits into
rocky-developfrom
feat/mgs-5747

Conversation

@a9a

@a9a a9a commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b19fd0a381

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

default:
id_prefix: '061_'
backend: "{{ magento_redis_cache_backend_fqcn }}"
backend: \Magento\Framework\Cache\Backend\Redis

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the legacy Redis backend selection

When this role is used for Magento <2.3.5 with magento_redis_cache_backend_legacy: yes, this hardcoded backend ignores the legacy switch that the commit removed, so the generated env.php references \Magento\Framework\Cache\Backend\Redis, which the previous defaults explicitly noted is unavailable on those versions. That breaks Redis default/page cache configuration for those legacy deployments; keep the backend FQCN templated or otherwise preserve the legacy path.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cm_Cache_Backend_Redis is no longer used and Magento < 2.3.5 is not supported

@a9a a9a force-pushed the feat/mgs-5747 branch from b19fd0a to bc863ae Compare July 9, 2026 12:38
@a9a a9a requested review from MariuszJozwiak and Szpadel July 9, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants