Seanaye/feat/non null soup realtime - #6282
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (15)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe GraphQL cache-only projection plugin now requires explicit operation opt-in and validates configured names and fields. Web codegen opts in Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The updated Soup hydration and cache-projection behavior is consistently implemented and tested, with no actionable merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR removes the nullability of items returned from soup realtime, and logs the error if the item cannot be found
Note
Low Risk
Build-time codegen and config only; tighter validation reduces accidental type generation with no runtime API changes in the shown diff.
Overview
GraphQL cache-only projection codegen is now opt-in instead of emitting a
*Resulttype for every operation that uses@cacheOnly. The codegen plugin acceptscacheOnlyResultOperations; web codegen listsSoupBackfillas the sole consumer (hydration paths that need types with cache-only fields stripped).The plugin fails fast on unknown operation names and on listed operations that have no
@cacheOnlyfields. Tests were updated for empty config, validation errors, and projection only for named operations.Cargo.lockbumpscache-wasmto 0.6.6 and addstracingto thecomplete_graphdev dependency graph (lockfile only in this diff).Reviewed by Cursor Bugbot for commit fcaddfb. Bugbot is set up for automated code reviews on this repo. Configure here.