feat(agent_harness_service): remove legacy alb

[whutchinson98]

Note

High Risk
Infrastructure cutover changes live routing, DNS, ECS load balancer attachments, and client default URLs; mis-deploy could break control API, websockets, or egress until configs are updated.

Overview
Moves agent harness control traffic off the dedicated agent-harness*.macro.com hostname onto the shared gateway at /agent-harness (prod and dev). macrod defaults and tests now point api_url at gateway.macro.com/agent-harness (and dev equivalent); websocket gateway URLs follow that base.

In Pulumi, control registers only with the gateway ServiceTargetGroup (/agent-harness, /agent-harness/*); BASE_URL comes from getServiceUrl(ServiceUrl.AGENT_HARNESS_SERVICE_URL). The legacy control DNS record, dedicated control target group, and ECS registration on the old ALB are removed. Sandbox egress stays on agent-harness-egress*.macro.com on the retained ALB, using serviceLoadBalancer with createDefaultTargetGroup: false so the HTTPS default action is a fixed 404 and only the host rule forwards egress.

serviceLoadBalancer gains typed overloads for optional default target group creation (404 vs forward). New source-parse tests lock routing shape and helper behavior; a stack README documents cutover and verification steps.

^{Reviewed by Cursor Bugbot for commit d89d4e1. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 7128b089-9266-46b2-af86-c976ddaa2235

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 53e22cf1-8a30-4fcb-b697-d945ce576273

📥 Commits

Reviewing files that changed from the base of the PR and between 4757c13 and bd9728f.

📒 Files selected for processing (9)

• crates/coding_agent_worker/default.macrod.toml
• crates/coding_agent_worker/src/config/test.rs
• crates/coding_agent_worker/src/tui/config_form.rs
• crates/coding_agent_worker/src/tui/config_form/test.rs
• infra/packages/shared/src/gateway_priorities.ts
• infra/stacks/agent-harness-service/README.md
• infra/stacks/agent-harness-service/agent_harness_service.ts
• infra/stacks/agent-harness-service/index.ts
• infra/stacks/agent-harness-service/legacy-alb.test.ts

💤 Files with no reviewable changes (1)

• infra/stacks/agent-harness-service/index.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.

---

📝 Summary

Summary by CodeRabbit

• New Features

  • Agent harness control and sandbox egress traffic now route through the shared gateway.
  • Added dedicated priority handling for agent harness egress routing.
  • Updated production and development gateway endpoints.

• Documentation

  • Added gateway routing, cutover, validation, and local testing guidance.

• Bug Fixes

  • Improved routing precedence to ensure sandbox egress traffic reaches the correct destination.

Walkthrough

The agent harness service now routes control and egress traffic through the shared gateway ALB. Production and development URLs use gateway paths. A new egress gateway service and priority were added. The dedicated service ALB and related resources were removed. DNS, target groups, security groups, listener dependencies, and service configuration were updated. AST-based tests validate the migration, and the README documents routing and verification steps.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to bd972

No actionable merge risk remains from the verified review scope.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title uses the required Conventional Commits format with the feat type, describes the removal of the legacy ALB, and is 46 characters long.
Description check	✅ Passed	The description directly explains the ALB removal, shared gateway routing, DNS changes, egress priority, configuration updates, and added tests.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}