LYT-1004: restore slideout and bar open/close animations - #672
Open
ashyablok-cs wants to merge 1 commit into
Open
LYT-1004: restore slideout and bar open/close animations#672ashyablok-cs wants to merge 1 commit into
ashyablok-cs wants to merge 1 commit into
Conversation
Transitions were dropped from .pf-widget in 5ae45dd to fix a modal CLS regression, which left slideouts and bars snapping into place. Restore the motion using composited properties only: widgets now sit at their final offsets and are pushed off-screen with a transform, so no layout property is animated and the CLS contribution stays at zero. - add .slide-transition() mixin (transform/opacity/visibility) - slideouts: translate off-screen per position; the vertically centered left/right variants compose translateX with their translateY(-50%) so they hold their centering for the whole transition - bars: translateY off the top/bottom edge instead of moving top/bottom - rebuild dist/pathfora.css and dist/pathfora.min.css Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transitions were dropped from .pf-widget in 5ae45dd to fix a modal CLS regression, which left slideouts and bars snapping into place.
Restore the motion using composited properties only: widgets now sit at their final offsets and are pushed off-screen with a transform, so no layout property is animated and the CLS contribution stays at zero.