Fix aria-labelledby typo on dialog widget containers - #669
Open
sean-cstk wants to merge 1 commit into
Open
Conversation
The dialog container for modal/gate widgets used aria-labeledby (one L), which is not a valid ARIA attribute and is silently ignored by assistive technology. As a result these dialogs had role="dialog" + aria-modal but no accessible name, so screen readers announced an unnamed dialog. Correct the spelling to aria-labelledby (two L) so it points at the existing id="pf-widget-headline" element. Spelling-only change across the 7 templates that render a dialog container (message/form/subscription modal+gate and sitegate/gate) plus the built dist bundles. No behavior, markup structure, or layout changes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 20, 2026
sean-cstk
marked this pull request as ready for review
August 20, 2026 20:38
cthorn-cs
approved these changes
Aug 21, 2026
cthorn-cs
left a comment
cthorn-cs
left a comment
There was a problem hiding this comment.
LGTM — aria-labeledby -> aria-labelledby is a valid-attribute correction; grepped the repo, nothing referenced the misspelling, and CI's green. Gives the modal/gate dialogs their accessible name, no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The dialog container for
modalandgatewidgets usedaria-labeledby(one L) instead ofaria-labelledby(two L).aria-labeledbyis not a valid ARIA attribute, so assistive technology silently ignores it. The result: these dialogs carryrole="dialog"+aria-modal="true"but have no accessible name, so screen readers announce an unnamed dialog.Change
Spelling-only correction to
aria-labelledbyso the attribute points at the existingid="pf-widget-headline"element. Applied across the 7 templates that render a dialog container:src/templates/message/{modal,gate}.htmlsrc/templates/form/{modal,gate}.htmlsrc/templates/subscription/{modal,gate}.htmlsrc/templates/sitegate/gate.htmlPlus the built bundles
dist/pathfora.jsanddist/pathfora.min.js(regenerated string only).No behavior, markup structure, or layout changes. Verified:
aria-labeledbycount 7 → 0;aria-labelledby1 → 8 per file (the one pre-existing correct use inbuild-form-element.jsis untouched).Scope
This PR fixes only the misspelled attribute. It does not add dialog semantics to non-modal layouts (slideout / bar / inline), which is a separate, larger accessibility gap tracked separately.
Context
Surfaced via a customer accessibility report (screen readers not exposed to Experiences).