table.drop & linter improvements for table.remove - #249
Open
InfraredGodYT wants to merge 15 commits into
Open
Conversation
Removing the use of ipairs in examples
Introduces the `table.drop` method for removing table elements by value and adds a linter rule to warn against potential misuse of `table.remove`.
Author
|
My mistake, used an old fork. Ignore the previous commits. |
InfraredGodYT
marked this pull request as draft
August 23, 2026 02:56
InfraredGodYT
marked this pull request as ready for review
August 25, 2026 16:53
Might edit these into the RFC itself depending on feedback.
nnullcolumn
reviewed
Aug 27, 2026
Updated the proposed function signature from `max` to `count` & corrected some typos. Accounted for the use of `assert` to prevent the current footgun with `table.remove`.
Updated the table.drop function to return the number of removed elements and specified errors for readonly tables or `count` values <= 0. Enhanced the linter warning for table.remove with a more clear warning message & better semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered