Skip to content

Bug fix for web-fragments.xml (fixes alertviewer route) - #90

Merged
kpuriIpac merged 1 commit into
mainfrom
bug-fix-alerts
Jul 16, 2026
Merged

Bug fix for web-fragments.xml (fixes alertviewer route)#90
kpuriIpac merged 1 commit into
mainfrom
bug-fix-alerts

Conversation

@kpuriIpac

Copy link
Copy Markdown
Collaborator

Description:

  • Upon inspection, I found the built suit.jar did not have suit's web-fragment.xml, which contains the servlet mapping for alertviewer
  • The fix below attempts to put web-fragment.xml into suit.jar (firefly is a little different in that we put the web.xml file directly into the WAR).
  • Open to a different/better solution, but I tested suit locally and this fixes the alertviewer issue.

Testing:

  • check out this branch, build it (you might need to remove the suit app from webapps in tomcat, and redeploy suit and restart tomcat), and try and access: http://localhost:8080/suit/alertviewer/
    • also do a couple of searches and ensure the results in UI look good (after our react-split-pane upgrade)

@kpuriIpac
kpuriIpac requested review from loitly and robyww July 16, 2026 18:34
@kpuriIpac kpuriIpac self-assigned this Jul 16, 2026
@kpuriIpac kpuriIpac added the bug label Jul 16, 2026

@robyww robyww left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@loitly loitly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I’ve verified that the file has been added to the jar.

@kpuriIpac
kpuriIpac merged commit fe436a0 into main Jul 16, 2026
1 check passed
@kpuriIpac
kpuriIpac deleted the bug-fix-alerts branch July 16, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants