Skip to content

fix SIP auth, Opus decoder, and CI security gates - #41

Merged
loreste merged 3 commits into
mainfrom
agent/fix-security-opus-ci-claims
Aug 10, 2026
Merged

fix SIP auth, Opus decoder, and CI security gates#41
loreste merged 3 commits into
mainfrom
agent/fix-security-opus-ci-claims

Conversation

@loreste

@loreste loreste commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Summary

  • fixes SIP digest nonce replay sequencing, parser binding, and fail-closed nonce entropy tests
  • pins callback HTTP dialing to the validated resolved IP to close DNS rebinding gaps
  • replaces the approximate Opus path with a libopus-backed CGO decoder and explicit no-CGO failure
  • narrows gosec global exclusions by moving reviewed suppressions to local callsites
  • hardens integration CI compose startup with health checks and updates docs for experimental codec/clustering claims

Validation

  • gosec include G201,G204,G304,G401,G501: 0 issues
  • workflow-equivalent blocking gosec exclude G115,G301,G302,G306,G404: 0 issues
  • docker compose -f docker-compose.test.yml config
  • go test ./pkg/auth ./pkg/media ./pkg/audio ./pkg/security ./pkg/backup ./pkg/database
  • CGO_ENABLED=0 go test ./pkg/media ./pkg/auth
  • CGO_ENABLED=1 go test ./pkg/media
  • CGO_ENABLED=0/1 go test -run ^$ ./...
  • git diff --check

Note: pkg/security listener-dependent tests required rerun outside the sandbox because httptest local bind was blocked there.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ebf60135-c48b-4505-86ee-0a3e497c8ba2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread pkg/media/opus_decoder_cgo.go Fixed
Comment thread pkg/media/opus_decoder_cgo.go Fixed
@loreste
loreste marked this pull request as ready for review August 10, 2026 11:12
@loreste
loreste merged commit 13286d3 into main Aug 10, 2026
14 checks passed
@loreste
loreste deleted the agent/fix-security-opus-ci-claims branch August 10, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants