remote_window: add version compatible with Loop next-dev#80
Open
bjorkert wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
remote_windowpatches do not apply to the Loopnext-devbranch, so the customization shows as incompatible.On next-dev the remote-command and dosing path was restructured (async/await delivery, the dosing delegate moved from
DeviceDataManagertoLoopAppManager, and several store APIs changed), so the original ~1700-line patch no longer applies. This version reproduces the customization's two behaviors with a smaller, retargeted change (14 files across theLoop,LoopKit, andNightscoutServicesubmodules):Test
Requires LoopWorkspace on the Loop
next-devbranch. No lnl-scripts change is needed; onlyPATCH_BRANCHis overridden.reset command
This command resets the branch to default state.
apply
Suggested checks (Nightscout + pump simulator, Remote Commands enabled): a single remote bolus; the same command sent twice (rejected as duplicate); a second command within 10 minutes covered by a prior bolus (reduced or refused); an OTP older than 10 minutes (expired); remote carbs with a recent carb entry (rejected).