chore: discrete check-only CI; local validate stays fix + verify - #5
Merged
Conversation
CI (pr-check + release) and prepublishOnly no longer run `npm run validate` (which auto-fixes via eslint --fix). They now run discrete check-only steps (lint:check, typecheck, build, test) so CI never mutates and a red run names the exact gate. Adds `lint:check`; `npm run validate` remains the local fix + verify convenience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings ecswatch in line with the platform validate contract: CI never auto-fixes; local
npm run validatedoes.npm run validate, which runseslint --fix— CI shouldn't mutate, and a fixable lint error should fail CI so it gets fixed locally first.pr-check.ymlandrelease.ymlnow run discrete check-only steps:lint:check,typecheck,build,test. A red run names the exact gate.prepublishOnlyswitched fromnpm run validateto the same check-only chain.lint:check(eslint .).npm run validatestays the local fix + verify convenience (lint --fix+ typecheck + build + test).Part of standardizing validate across repos (infra #102).
Test plan
npm run lint:check && npm run typecheck && npm run build && npm run testpass locally (15/15 tests)