fix: split fetch network errors from unreachable server failures - #96
Merged
Conversation
When fetch throws before any HTTP response, classify offline/abort as NETWORK_ERROR and unreachable API hosts while online as INTERNAL_ERROR (status 500) with diagnostic data for logging. Co-authored-by: Cursor <cursoragent@cursor.com>
Connection refused and online Failed to fetch are service reachability failures (503), not unhandled handler bugs (500). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Inline offline vs online handling in CallspecClient instead of a separate classifyFetchFailure module with regex heuristics. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Tests pass isOnline like fetch; production default still reads navigator.onLine. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was going wrong
When
fetchthrows before any HTTP response, the client always returnedNETWORK_ERROR(status0). That mixed “device offline” with “API unreachable while online,” so frontends showed “check your connection” when the server was down.What this PR changes
Two rules in
CallspecClient.callResultwhenfetchthrows:navigator.onLine === false, or request abortedNETWORK_ERROR0SERVICE_UNAVAILABLE503No message parsing or cause-chain heuristics — browsers already throw the same
Failed to fetchfor both cases, so we only split on offline vs not.HTTP response normalization is unchanged.
Breaking change
Online + unreachable API now returns
SERVICE_UNAVAILABLEinstead ofNETWORK_ERROR. App frontends that mapSERVICE_UNAVAILABLE→ServiceBusyget the right UX without extra work.Test plan
npm run validate