Expose observation metadata through simulator interfaces - #340
Expose observation metadata through simulator interfaces#340AlexanderFengler wants to merge 4 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Depends on #339.
Scope
Simulator.get_observation_metadata()*_deadlinevariants through the same model-config path as the simulator, preserving exact base-model response labelsCompatibility boundary
This is additive, out-of-band metadata. It does not change
simulator(),Simulator.simulate(),hssm_sim_wrapper, result dictionaries, result metadata, or thethree-value
validate_simulator_fun()contract.The descriptor's
obs_dimis semantic and derived from the schema. The existing wrapperattribute remains a legacy output-width contract. Consequently, a response-only
inverse-temperature-softmax model reports semantic width one while its unchanged HSSM
wrapper still returns the historical two-column dummy-RT/response array.
Metadata lookup remains fail-closed: unknown producers and incomplete declarations do
not acquire schemas from
nchoices, legacyobs_dim, result keys, sampled values, orthe HSSM fallback labels.
Review hardening
intentionally omit schema declarations
state; copied response labels and schema declarations remain isolated
introspection agree
Verification
git diff --checkddm_deadlinewrapper executionconstruction, 2 passed with candidate provenance asserted
Deferred
RLSSM
ModelConfig/AssembledModeladoption, the broader downstream compatibilitymatrix, contributor documentation, and any consumer switch to normalized results remain
separate stacked work.