Skip to content

Declare exact choices for legacy configs - #338

Open
AlexanderFengler wants to merge 1 commit into
codex/observation-producer-schemafrom
codex/complete-registered-choice-labels
Open

Declare exact choices for legacy configs#338
AlexanderFengler wants to merge 1 commit into
codex/observation-producer-schemafrom
codex/complete-registered-choice-labels

Conversation

@AlexanderFengler

Copy link
Copy Markdown
Member

Depends on #337.

Why

Five built-in model configs declared only a choice count, not their exact response labels. The legacy HSSM wrapper therefore used its three-label fallback. That happened to match four models, but incorrectly exposed the four-choice tradeoff_weibull_no_bias model as supporting only [0, 1, 2].

Scope

  • declare [0, 1, 2] for the four three-choice configs
  • declare [0, 1, 2, 3] for tradeoff_weibull_no_bias
  • verify each declaration against simulator-owned possible_choices metadata and observed outputs
  • verify the exact labels reach the unchanged three-value HSSM simulator contract

This is a standalone config correction. It does not yet classify observation schemas or change simulator output.

Verification

  • focused config and HSSM-support suite: 106 passed
  • simulator, class, and dataset-integration regression slice passed
  • HSSM test_make_hssm_rv passed with candidate ssms provenance confirmed
  • repository-wide Ruff check and format check passed
  • git diff --check

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: aaa87d8e-47b4-4f0a-8384-4295b26e7ccb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
unittests 94.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ssms/config/_modelconfig/dev_rlwm_lba.py 100.00% <ø> (ø)
ssms/config/_modelconfig/lba.py 100.00% <ø> (ø)
ssms/config/_modelconfig/lca.py 100.00% <ø> (ø)
ssms/config/_modelconfig/tradeoff.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant