Declare exact choices for legacy configs - #338
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Depends on #337.
Why
Five built-in model configs declared only a choice count, not their exact response labels. The legacy HSSM wrapper therefore used its three-label fallback. That happened to match four models, but incorrectly exposed the four-choice
tradeoff_weibull_no_biasmodel as supporting only[0, 1, 2].Scope
[0, 1, 2]for the four three-choice configs[0, 1, 2, 3]fortradeoff_weibull_no_biaspossible_choicesmetadata and observed outputsThis is a standalone config correction. It does not yet classify observation schemas or change simulator output.
Verification
test_make_hssm_rvpassed with candidatessmsprovenance confirmedgit diff --check