feat: add angle_extended as a supported model - #1298
Conversation
The angle model with drift bounds widened to (-6, 6), for designs that produce strong evidence. Bounds and parameter order are asserted against the ssms registry by the existing cross-check test, now parametrized over this model too. Raises the ssm-simulators floor to >=0.14.0, the first release containing the model. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe change adds ChangesAngle Extended Model Support
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds the angle_extended model with its supported bounds and documentation. Registry validation covers its parameter contract, and no merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 5 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds
angle_extended— the angle model with drift bounds widened to (−6, 6) — as a built-in.src/hssm/modelconfig/angle_extended_config.py; registered inSupportedModels, both constructor docstrings, and the docs model table.v (−6, 6),a (0.3, 3),z (0.1, 0.9),t (0.001, 2),theta (−0.1, 1.3).test_config_matches_ssms_registryextended to cover it —list_paramsorder, choices, and the bounds dict are asserted againstssms.config.model_configelement-for-element.ssm-simulatorsfloor to>=0.14.0— the first release containingangle_extended(v0.13.2 predates it), so without the bump a pip user could hold a registered model the simulator doesn't know.Ordering note:
angle_extended.onnxis onfranklab/HSSM_staging(commit 05feb708) with a passing 240-fit recovery report bound to the artifact; the production promote tofranklab/HSSMis queued behind this PR's review, same sequence asgamma_drift_angle(#1296). Recommend merging this only once the promote lands, for the same clean-install-404 reason CodeRabbit raised on #1296.Testing: 944 passed (fast suite) against released
ssm-simulators 0.14.0; repo-root ruff unchanged (10 pre-existing notebook findings on main, none in these files).🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
angle_extendedmodel.Maintenance
ssm-simulatorsversion to 0.14.0.