Define canonical response-domain configuration - #1270
Merged
AlexanderFengler merged 3 commits intoAug 30, 2026
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
AlexanderFengler
merged commit Aug 30, 2026
86c92f5
into
codex/1265-response-domains
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
response_domainsmapping keyed by the physical non-RT columns inConfig.responsechoicesthrough the same resolver while preserving established DDM, multichoice, RLSSM, and aDDM behaviorCloses the 3A slice of #1265 and targets the cumulative draft sink #1266.
Contract
Config.responseremains the ordered physical DataFrame schema; this PR adds no semantic alias layerchoicesviewComplexity ledger
response_domainsfield on existing configuration/model objects and the optionalregister_model(response_domains=...)argument; no new exported class, enum, module, or registrychoicesremains an input and a derived view for exactly one categorical responseVerification
283 passed, 32 deselectedacross focused configuration, validation, missing/deadline, HSSM, RLSSM, aDDM, registration, and sampling-smoke compatibility testsruff check src/hssmruff format --checkon all changed Python filesmypy src/hssm(83 files)pyrefly checkgit diff --checkpython scripts/check_docs_weight.pyThe existing aDDM five-draw sampling smokes ran only as compatibility tests; no benchmark, recovery study, evidence artifact, or scientific inference was produced.
Deferred
response_kind/response_boundsbecome resolver adapters only in the finalmain -> devintegration