Skip to content

ci: point the slow-test matrix at tests/integration - #1241

Open
AlexanderFengler wants to merge 1 commit into
mainfrom
drift/2026-08-24-slow-test-paths
Open

ci: point the slow-test matrix at tests/integration#1241
AlexanderFengler wants to merge 1 commit into
mainfrom
drift/2026-08-24-slow-test-paths

Conversation

@AlexanderFengler

@AlexanderFengler AlexanderFengler commented Aug 24, 2026

Copy link
Copy Markdown
Member

Purpose

The weekly drift run's slow suite has been failing every leg since the
2026-08-24 scheduled run. Six of the nine legs never collected a single test:

ERROR: file or directory not found: tests/slow/test_mcmc.py
ERROR: file or directory not found: tests/slow/test_missing_data_mcmc.py

85f2f032 ("moved all slow tests to integration folder") relocated every slow
test to tests/integration/ and landed on main on 2026-08-17 15:02 — after
that morning's green drift run, which is why 2026-08-24 was the first run to
see it. run_slow_tests.yml was not updated with it.

Implementation

  • Repoint the Missing Data and Core MCMC batches at tests/integration/.
  • Repoint the four --ignore= paths in the Remaining Slow batch. These were
    not merely cosmetic: a non-matching --ignore is silently accepted by
    pytest, so Remaining Slow had been re-collecting the Core MCMC and Missing
    Data files that the dedicated batches already own.
  • Refresh the one stale tests/slow/ mention in the tests/conftest.py
    docstring for _slow_test_memory.

No test code or markers changed — only the paths naming it.

Verification

Each of the four referenced files was confirmed to exist at its new
tests/integration/ path on main; tests/slow/ no longer exists in the
tree. Beyond that this change is verified by its own CI: the slow suite is the
thing under repair, so this PR's run is the test.

Out of scope

The Remaining Slow legs fail for an unrelated, genuine reason —
tests/test_hssm.py::test_transform_params_general[include4-IndexError] now
raises KeyError: 'invalid_formula' instead of IndexError. That is a
behaviour change, tracked separately; this PR is expected to fix the six
collection-error legs only.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Updated slow-test workflow batches to use the integration test suite.
    • Revised test documentation to reflect the current integration test location.

85f2f03 moved every slow test from tests/slow/ to tests/integration/ but
left run_slow_tests.yml pointing at the old paths. The first scheduled slow
run after it landed (2026-08-24) failed 6 of 9 legs with

    ERROR: file or directory not found: tests/slow/test_mcmc.py
    ERROR: file or directory not found: tests/slow/test_missing_data_mcmc.py

The "Remaining Slow" leg failed differently but was also affected: its
--ignore paths no longer matched anything, so it silently re-collected the
Core MCMC and Missing Data files that the dedicated batches already own.

Repoints all four file references and refreshes the one stale tests/slow/
mention in the tests/conftest.py docstring.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 89ab5d65-f5c7-4255-87b0-5544cda09df2

📥 Commits

Reviewing files that changed from the base of the PR and between 5e49914 and 7b9310c.

📒 Files selected for processing (2)
  • .github/workflows/run_slow_tests.yml
  • tests/conftest.py

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The slow-test workflow now uses tests/integration/ for all three matrix batches. The _slow_test_memory fixture documentation uses the same path reference. No executable test behavior changed.

Changes

Slow-test path updates

Layer / File(s) Summary
Update slow-test references
.github/workflows/run_slow_tests.yml, tests/conftest.py
The workflow matrix and exclusion paths now reference tests/integration/. The fixture documentation now uses the updated path.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 7b931

This localized change updates slow-test paths and a related documentation reference; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: digicosmos86, cpaniaguam

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: updating the CI slow-test matrix to use tests/integration paths.
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch drift/2026-08-24-slow-test-paths

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant