ci: drop duplicate graphviz install from notebook env setup - #1219
ci: drop duplicate graphviz install from notebook env setup#1219AlexanderFengler wants to merge 1 commit into
Conversation
PRs #1184 and #1188 landed on the same day and each added an apt-get install of graphviz to the notebooks composite action, so every notebook shard runs `apt-get update && apt-get install -y graphviz` twice. Keep the first step; drop the second. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan includes up to 2 reviews per rolling hour; 1 remains after this review. 📝 WalkthroughWalkthroughThis pull request removes a duplicate Graphviz installation step from the notebook setup composite action. The action now continues from the existing Graphviz setup to the ChangesNotebook environment setup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized cleanup removes a redundant Graphviz installation while retaining the step that provides dot for notebook jobs; no actionable merge-blocking risk remains beyond normal checks. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mechanical drift healing (weekly
audit-driftsession, 2026-08-17)..github/setup-env-notebooks/action.ymlinstalled graphviz twice: PRs ci: install the graphviz binary for notebook checks #1184 and ci: run the notebook drift check weekly, and fix its environment #1188 landed within two hours of each other on 2026-08-13 and each added anapt-get update && apt-get install -y graphvizstep.apt-get updateon each of the 4 notebook shards per drift run.No behavior change —
dotis still on PATH for every notebook job. Verified the action still parses and retains exactly one graphviz step.Context: the
hssm-notebooksfreshness budget went red because run 31734899653 (2026-08-13 19:15 UTC) failed all 4 shards onExecutableNotFound: 'dot'— that run started before either graphviz fix merged. A fresh notebook run is in flight to clear the budget: https://github.com/lnccbrown/HSSM/actions/runs/32063688775Summary by CodeRabbit