Skip to content

Add mapping support for BWT MEDO CONNECT Wi‑Fi (PDPH1H1HAW1B0 / FW539494) - #45

Closed
lmaertin with Copilot wants to merge 2 commits into
mainfrom
copilot/integrate-bwt-medo-connect-wifi
Closed

Add mapping support for BWT MEDO CONNECT Wi‑Fi (PDPH1H1HAW1B0 / FW539494)#45
lmaertin with Copilot wants to merge 2 commits into
mainfrom
copilot/integrate-bwt-medo-connect-wifi

Conversation

Copilot AI commented May 25, 2026

Copy link
Copy Markdown
Contributor

A newly reported BWT MEDO CONNECT Wi‑Fi unit (PDPH1H1HAW1B0, FW539494) was not recognized because no model/firmware mapping existed. This PR adds an explicit mapping so the device can be parsed with the existing pH-family schema.

  • New model mapping

    • Added src/pooldose/mappings/model_PDPH1H1HAW1B0_FW539494.json.
    • Mapping is aligned with the existing pH-only layout and uses the correct PDPH1H1HAW1B0_FW539494_* label/combo prefixes for conversion entries.
  • Coverage for the new mapping

    • Extended tests/test_mapping_info.py with TestMedoConnectMapping to verify:
      • mapping file loads for PDPH1H1HAW1B0 + 539494
      • conversion keys resolve under the new prefix
      • expected entity-type counts are present
  • Supported-device documentation

    • Updated supported devices tables in:
      • README.md
      • docs/device-support.md
    • Added the BWT MEDO CONNECT Wi‑Fi row with product/firmware and mapping note.
mapping_info = await MappingInfo.load("PDPH1H1HAW1B0", "539494")
assert mapping_info.status == RequestStatus.SUCCESS

Copilot AI changed the title [WIP] Add integration for BWT MEDO CONNECT wifi Add mapping support for BWT MEDO CONNECT Wi‑Fi (PDPH1H1HAW1B0 / FW539494) May 25, 2026
Copilot AI requested a review from lmaertin May 25, 2026 05:11
@lmaertin

Copy link
Copy Markdown
Owner

@copilot MODEL_ALIASES not work here? The mapping file introduces new keys?

Copilot AI commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

@copilot MODEL_ALIASES not work here? The mapping file introduces new keys?

MODEL_ALIASES is not enough in this case. For this device, raw keys and label tokens are prefixed with PDPH1H1HAW1B0_FW539494_*. If we alias to PDPH1H1HAW100, the client builds prefix PDPH1H1HAW100_FW539494_ (client.py), so lookups/conversions won’t match the payload.

The new mapping file does not add new entity names/logic; it keeps the same pH-family schema and only adapts conversion/options tokens to the reported model+FW prefix.

@lmaertin

Copy link
Copy Markdown
Owner

No chlorine or orp target keys available?

@lmaertin

Copy link
Copy Markdown
Owner

in progress in another feature-branch

@lmaertin lmaertin closed this May 27, 2026
@lmaertin
lmaertin deleted the copilot/integrate-bwt-medo-connect-wifi branch May 29, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intégration du BWT MEDO CONNECT wifi (SEKO POOLDOSE)

2 participants