refactor(preset): rename the generic preset to auto#65
Open
izzet wants to merge 1 commit into
Open
Conversation
Rename the `analyzer/preset=generic` config-group option to `analyzer/preset=auto`, matching what the preset actually does: it auto-discovers one layer per distinct `cat` in the trace. - `AnalyzerPresetConfigGeneric` -> `AnalyzerPresetConfigAuto` - ConfigStore registration and the preset's `name` field now use "auto" - `tests/test_generic_preset_e2e.py` -> `tests/test_auto_preset_e2e.py` No backward-compatible alias is registered; `analyzer/preset=generic` now fails with Hydra's standard config-group error, which lists the available options.
izzet
force-pushed
the
refactor/rename-generic-preset-to-auto
branch
from
July 26, 2026 01:07
af459cb to
d4cac58
Compare
rayandrew
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the
genericanalyzer preset toauto, which better describes what it does: it discovers one layer per distinctcatin the trace rather than being a generic fallback.AnalyzerPresetConfigGeneric→AnalyzerPresetConfigAutoanalyzer/preset=generic→analyzer/preset=autotests/test_generic_preset_e2e.py→tests/test_auto_preset_e2e.py(viagit mv, 92% similarity), plus thetest_generic_preset_*function names in it and intest_category_layers.pyautoindocs/configuration.rst, which previously listed onlyposixanddlioNo backward-compatible alias
Deliberate. The preset landed in #61, one commit before this branch point — it has never appeared in a tagged release, in the docs, or in CI, so there is no installed base of
preset=genericinvocations. An alias would also be misleading: the node's ownnamefield is nowauto, sopreset=genericwould resolve to a preset that reports itself asauto. Hydra's error already lists the valid options:Note that
genericalso appears in unrelated contexts (e.g.self.generic_visit(node), a PythonastAPI) which are untouched.Verification
pytest -m smoke— 155 passed, 32 deselectedpytest tests/test_auto_preset_e2e.py tests/test_category_layers.py— 52 passedanalyzer/preset=autoproduces a populated layer breakdown with the auto-discovered category layersMerge order
Please merge before the
dlio/aipreset rename, which builds on this branch and touches the same preset registry. Until this merges, that PR will also display these commits.