Skip to content

refactor(preset): rename the generic preset to auto#65

Open
izzet wants to merge 1 commit into
llnl:developfrom
izzet:refactor/rename-generic-preset-to-auto
Open

refactor(preset): rename the generic preset to auto#65
izzet wants to merge 1 commit into
llnl:developfrom
izzet:refactor/rename-generic-preset-to-auto

Conversation

@izzet

@izzet izzet commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

Renames the generic analyzer preset to auto, which better describes what it does: it discovers one layer per distinct cat in the trace rather than being a generic fallback.

  • AnalyzerPresetConfigGenericAnalyzerPresetConfigAuto
  • config group value analyzer/preset=genericanalyzer/preset=auto
  • tests/test_generic_preset_e2e.pytests/test_auto_preset_e2e.py (via git mv, 92% similarity), plus the test_generic_preset_* function names in it and in test_category_layers.py
  • documents auto in docs/configuration.rst, which previously listed only posix and dlio

No backward-compatible alias

Deliberate. The preset landed in #61, one commit before this branch point — it has never appeared in a tagged release, in the docs, or in CI, so there is no installed base of preset=generic invocations. An alias would also be misleading: the node's own name field is now auto, so preset=generic would resolve to a preset that reports itself as auto. Hydra's error already lists the valid options:

In 'config': Could not find 'analyzer/preset/generic'
Available options in 'analyzer/preset':
	auto
	dlio
	dlio-prev
	posix

Note that generic also appears in unrelated contexts (e.g. self.generic_visit(node), a Python ast API) which are untouched.

Verification

  • pytest -m smoke — 155 passed, 32 deselected
  • pytest tests/test_auto_preset_e2e.py tests/test_category_layers.py — 52 passed
  • CLI with analyzer/preset=auto produces a populated layer breakdown with the auto-discovered category layers

Merge order

Please merge before the dlio/ai preset rename, which builds on this branch and touches the same preset registry. Until this merges, that PR will also display these commits.

Rename the `analyzer/preset=generic` config-group option to
`analyzer/preset=auto`, matching what the preset actually does: it
auto-discovers one layer per distinct `cat` in the trace.

- `AnalyzerPresetConfigGeneric` -> `AnalyzerPresetConfigAuto`
- ConfigStore registration and the preset's `name` field now use "auto"
- `tests/test_generic_preset_e2e.py` -> `tests/test_auto_preset_e2e.py`

No backward-compatible alias is registered; `analyzer/preset=generic`
now fails with Hydra's standard config-group error, which lists the
available options.
@izzet
izzet force-pushed the refactor/rename-generic-preset-to-auto branch from af459cb to d4cac58 Compare July 26, 2026 01:07
@izzet
izzet requested a review from rayandrew July 26, 2026 01:19
@izzet izzet self-assigned this Jul 26, 2026
@izzet izzet added the enhancement New feature or request label Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants