Remove unncessary requirement for using the platform default stream in LoopFuser - #387
Merged
Conversation
adayton1
commented
Jul 23, 2026
adayton1
commented
Member
- CAMP v2026.07 no longer allows clients to determine the default stream on a translation unit basis due to the ODR violations that almost certainly will occur, such as here in the LoopFuser.
- From a visual inspection, it does not appear that the LoopFuser actually relies on the 0 stream, and in fact, it may be more dangerous for it to use a different stream than the rest of CARE.
- Client testing is underway to validate this change in at least one real application.
liu15
approved these changes
Jul 23, 2026
dtaller
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.