chore(release): 4.0.0 - #14
Merged
Merged
Conversation
Expose the NameID Format across metadata (IdP/SP `nameIdFormats`), AuthnRequest's NameIDPolicy, AuthnResponse, and LogoutRequest, so applications can request, read, and reuse the format alongside the identifier value (e.g. for SP-initiated logout). BREAKING CHANGE: `nameId` is now a `Litesaml\Models\Messages\NameId` value object (`value` + `format`) instead of a plain string on `AuthnResponse`, `LogoutRequest`, and as the `sendLogoutRequest()` parameter. Closes #7
sendAuthnResponse() built the assertion's Subject/NameID without any value or format, leaving no way for the IdP to honor a requested NameIDPolicy end-to-end. Adds an optional NameId parameter, consistent with the object already used by sendLogoutRequest(). Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
…#13) send*/handle* methods on both wrapper classes had accumulated one positional/named optional parameter per protocol detail (relayState, sessionIndex, nameIdPolicyFormat, nameId, plus bool $validate / ?Entity $issuer duplicated across 8 call sites). Replace all of it with a single ContextList $context parameter: a typed, variadic collection of Context value objects (RelayState, SessionIndex, NameIdPolicyFormat, Validate, NameId, Attribute). Validate(Entity $issuer) merges the old validate/issuer pair; since $issuer is a required constructor argument, "validate without an issuer" is no longer representable, so that runtime exception path is removed along with its tests. NameId and Attribute move from Litesaml\Models\Messages to Litesaml\Models\Messages\Context and now implement Context. sendLogoutRequest()'s NameId is no longer statically required; a missing one now throws SamlException at call time via ContextList::required(). Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.