feat: allow IdP to set NameID on sendAuthnResponse - #11
Merged
Conversation
sendAuthnResponse() built the assertion's Subject/NameID without any value or format, leaving no way for the IdP to honor a requested NameIDPolicy end-to-end. Adds an optional NameId parameter, consistent with the object already used by sendLogoutRequest(). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
william-suppo
added a commit
that referenced
this pull request
Jul 7, 2026
sendAuthnResponse() built the assertion's Subject/NameID without any value or format, leaving no way for the IdP to honor a requested NameIDPolicy end-to-end. Adds an optional NameId parameter, consistent with the object already used by sendLogoutRequest(). Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IdentityProviderWrapper::sendAuthnResponse()built the assertion'sSubject/NameIDwithout any value or format, so the IdP had no way to honor a requestedNameIDPolicyend-to-end.?NameId $nameId = nullparameter, reusing the sameNameIdvalue object already used bysendLogoutRequest()for consistency, and sets it on theSubjectin both the plain- and encrypted-attribute assertion branches.Test plan
composer test(73 tests, 185 assertions) — addedcan_send_authn_response_with_name_idcovering the IdP→SP round tripcomposer phpstan— no errors