Skip to content

fix(print): render page with white background - #215

Open
Resurgamz wants to merge 1 commit into
linuxdeepin:release/eaglefrom
Resurgamz:fix/print-white-background-eagle
Open

fix(print): render page with white background#215
Resurgamz wants to merge 1 commit into
linuxdeepin:release/eaglefrom
Resurgamz:fix/print-white-background-eagle

Conversation

@Resurgamz

@Resurgamz Resurgamz commented Jul 22, 2026

Copy link
Copy Markdown

在打印时调用 renderToImage(Qt::white),确保打印页面使用不透明白色背景。

Log:修复打印预览页面背景透明的问题,泣染页面图像时指定 Qt::white 作为背景色。
Bug: https://pms.uniontech.com/bug-view-221301.html

@sourcery-ai

sourcery-ai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the print dialog invocation so that the rendered page image uses a white background instead of the default, ensuring consistent visual output when printing.

Sequence diagram for printing a page with a white background

sequenceDiagram
  actor User
  participant TopTilte
  participant DrawBoard
  participant Page
  participant PageContext
  participant CPrintManager

  User->>TopTilte: trigger print action
  TopTilte->>DrawBoard: currentPage()
  DrawBoard-->>TopTilte: Page
  TopTilte->>Page: context()
  Page-->>TopTilte: PageContext
  TopTilte->>PageContext: renderToImage(Qt::white)
  PageContext-->>TopTilte: imageWithWhiteBackground
  TopTilte->>CPrintManager: showPrintDialog(imageWithWhiteBackground, topMainWindowWidget, pageName)
Loading

File-Level Changes

Change Details Files
Ensure the page image passed to the print dialog is rendered with a white background.
  • Modify the call to render the current page image to pass Qt::white as the background color parameter.
  • Keep the existing print dialog flow, including null checks for the page and its context, unchanged.
src/frame/toptoolbar.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider whether forcing a white background is always desired or if the print background color should be configurable or derived from the page/theme instead of hardcoded.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider whether forcing a white background is always desired or if the print background color should be configurable or derived from the page/theme instead of hardcoded.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Resurgamz
Resurgamz force-pushed the fix/print-white-background-eagle branch from a4a11c9 to a223f4e Compare July 22, 2026 13:15
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Resurgamz

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

在打印时调用 renderToImage(Qt::white),确保打印页面使用不透明白色背景。

Log: 修复打印预览页面背景透明的问题,渲染页面图像时指定 Qt::white 作为背景色。

Bug: https://pms.uniontech.com/bug-view-221301.html
@Resurgamz
Resurgamz force-pushed the fix/print-white-background-eagle branch from a223f4e to 03f18a6 Compare July 22, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants