Skip to content

chore: Update version to 6.5.45 - #512

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:master
Aug 6, 2026
Merged

chore: Update version to 6.5.45#512
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:master

Conversation

@add-uos

@add-uos add-uos commented Aug 6, 2026

Copy link
Copy Markdown
Contributor
  • update version to 6.5.45

log: update version to 6.5.45

Summary by Sourcery

Chores:

  • Update linglong package manifest to version 6.5.45.1.

- update version to 6.5.45

log: update version to 6.5.45
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

TAG Bot

TAG: 6.5.45
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai

sourcery-ai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the project version metadata to 6.5.45.1 for the deepin-camera package and prepares the Debian changelog for the new release.

File-Level Changes

Change Details Files
Bump application/package version to 6.5.45.1 for the new release.
  • Update the package.version field from 6.5.44.1 to 6.5.45.1 in the Linglong configuration
linglong.yaml
Prepare Debian changelog for the 6.5.45 release.
  • Add or update the top entry in debian/changelog to reflect the new 6.5.45 version (exact diff content not shown but implied by the description)
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:70分

■ 【总体评价】

提交仅包含版本号和日志变更,完全缺失核心修复代码,属于无效提交
因缺失实际源代码导致无法实现BUG修复目的,严重违反完整性要求扣30分

■ 【详细分析】

  • 1.语法逻辑(存在致命错误)✕

本次diff仅包含debian/changelog和linglong.yaml的文本修改,缺失了修复BUG-372435所需的实际C++或QML源代码文件。作为一个声称修复OpenGL预览渲染和帧所有权问题的提交,缺少核心逻辑实现,导致该提交实质上是无效的,无法通过编译验证修复效果。
潜在问题:提交不完整导致版本回退或功能缺失;打包构建后实际二进制文件不包含任何修复代码。
建议:补充涉及OpenGL渲染管线、帧缓冲或帧对象生命周期管理的实际源代码diff。

  • 2.代码质量(存在严重问题)✕

缺失核心业务代码,仅凭变更日志无法评估代码规范、命名、注释等质量指标。变更日志格式符合Debian标准,但掩盖不了源码缺失的严重质量问题。
潜在问题:代码审查流于形式,无法进行实质性Code Review。
建议:将完整的源码修改一并提交,确保diff包含所有相关文件的变更。

  • 3.代码性能(无性能问题)✓

由于未提供实际业务代码,不存在因本次修改引入的性能瓶颈或资源泄漏问题。
建议:在补充实际源码后,重点审查OpenGL帧所有权转移逻辑是否引入了不必要的内存拷贝或GPU阻塞。

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次提交仅涉及纯文本配置和日志文件的修改,不包含可执行逻辑、内存操作或外部输入处理,因此不存在安全漏洞。

  • 建议:在补充实际OpenGL渲染和帧管理代码后,需重点排查是否存在释放后使用(UAF)、越界读写或GPU显存泄漏等内存安全漏洞。

■ 【改进建议代码示例】

diff --git a/debian/changelog b/debian/changelog
index 799833a2..1e8e49d6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+deepin-camera (6.5.45) unstable; urgency=medium
+
+  * chore: Update version to 6.5.45
+  * fix(camera): fix OpenGL preview rendering and frame ownership (BUG-372435)
+
+ -- zhanghongyuan <zhanghongyuan@uniontech.com>  Thu, 06 Aug 2026 19:22:06 +0800
+
 deepin-camera (6.5.44) unstable; urgency=medium
 
   * chore: Update version to 6.5.44
diff --git a/linglong.yaml b/linglong.yaml
index 11bbfa90..b77a34e8 100644
--- a/linglong.yaml
+++ b/linglong.yaml
@@ -7,7 +7,7 @@ version: "1"
 package:
   id: org.deepin.camera
   name: "deepin-camera"
-  version: 6.5.44.1
+  version: 6.5.45.1
   kind: app
   description: |
     camera for deepin os.
diff --git a/src/opengl_renderer.cpp b/src/opengl_renderer.cpp
index 1234567..abcdefg 100644
--- a/src/opengl_renderer.cpp
+++ b/src/opengl_renderer.cpp
@@ -10,6 +10,8 @@ void OpenGLRenderer::updateFrame(std::shared_ptr<VideoFrame> frame) {
     if (!frame) return;
 
     std::lock_guard<std::mutex> lock(m_frameMutex);
-    m_currentFrame = frame;
+    // 修复帧所有权:确保在渲染线程安全接管前原帧不被销毁
+    m_pendingFrame = std::move(frame);
+    m_frameReady = true;
 }

@lzwind
lzwind merged commit 00fb2d0 into linuxdeepin:master Aug 6, 2026
20 of 21 checks passed
@deepin-bot

deepin-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.5.45
  • Tag SHA: a0a719bfe7606a2ea890d7b6f5892e1bcb386def
  • Commit SHA: 00fb2d03094dfe847db01f52096d0dffe13191b5
  • Tag Message:
    Release deepin-camera 6.5.45
    
    
  • Tagger:
    • Name: add-uos
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants