Add devices to disable for power saver, decoupleing balanced and powersaver

[dusklinux]

No description provided.

[linrunner]

Thanks in advance. I'm busy right now, but I'll check back when I have time.

[dusklinux]

No problem.

The code base was well written, and required only surgical edits because the groundwork was already laid out. I only added ~38 liines using the same logic you already had in place.

[linrunner]

This approach isn't complete yet, the topic is more complicated.

When switching from balanced to power-saver profile, the radios listed in DEVICES_TO_DISABLE_ON_SAV get disabled. However, when switching from power-saver back to balanced, nothing happens. I'm guessing that's not what you're expecting.

[dusklinux]

That's interesting, I'll re-test to make sure it works, and push the commit where it needs fixing.

[linrunner]

We'll need a DEVICES_TO_ENABLE_ON_BAT.

In addition, the fallback DEVICES_TO_DISABLE_ON_BAT -> _SAV is up for discussion. I consider it counterproductive and confusing in the extended scenario.

Finally, I'd like to consolidate the sections in tlp.conf; otherwise, it will become overwhelming. I'll do that myself once functionality is finished.

[dusklinux]

I have updated the pr to address your feedback:

Added DEVICES_TO_ENABLE_ON_BAT and DEVICES_TO_ENABLE_ON_SAV to give users explicit control over enabling specific devices when transitioning back to the balanced profile.

Removed the fallback behavior between _BAT and _SAV configuration options, making the profiles completely independent.

Updated tlp.conf.in with documentation for the new variables and removed fallback descriptions.

I have tested transitions between all profiles (performance, balanced, power-saver) on my system, and the devices now enable and disable correctly. I made sure to have it match the naming scheme that you already had in place.

I spent the last two hours figuring it out and fixing it. I've stress tested it every whichway, rest assured it works well now.

[linrunner]

Great. I'm still working on something else right now. I'll take a look at it after that.

[dusklinux]

Alright, I wont hold my breath,

[fayizshaffaq]

@dusklinux will tlp setup be re added to dusky after this is merged?

[dusklinux]

Yup.

[linrunner]

Your code works.

I merged it externally, not here on the platform. Please make sure in the future that there are no “commit accidents” in the history. A push --force to a dedicated branch is perfectly acceptable in such a case.

Before this goes to main, I’ll make some additional changes:

• Automated test
• Consolidate/shorten tlp.conf
• Replace DEVICES_TO_DISABLE/ENABLE_ON_STARTUP - we’ll handle that using the profile-specific variables (we’ll also need DEVICES_TO_DISABLE_ON_AC for that)
• Handle conflicting configurations; e.g., DEVICES_TO_DISABLE_ON_BAT=“wifi” and DEVICES_TO_ENABLE_ON_BAT=“wifi” cancel each other out, so no action is needed.
• Take into account profile changes after suspend/resume
• Consolidate the code even further

When someone points out an issue to me, I sometimes spontaneously come up with further ideas...

Stay tuned!

[dusklinux]

Perfect! Sounds great! I'll keep that in mind.
Thank you! Let me know if you need anything at all, any testing or whatever.

[linrunner]

Testing of course.

[dusklinux]

Anytime. Just let me know when, and provide a link to the project with the updated logic.

[Mylinde]

I would like to point out that two different things are being mixed here. Namely the energy source BAT/AC and energy profiles SAV/BAL/PRF, which can be configured for each regardless of the energy source. DEVICES_TO_DISABLE_ON_BAT/AC and DEVICES_TO_ENABLE_ON_BAT/AC would therefore have to be completely replaced by ON_SAV/BAL/PRF

[dusklinux]

I would like to point out that two different things are being mixed here. Namely the energy source BAT/AC and energy profiles SAV/BAL/PRF, which can be configured for each regardless of the energy source. DEVICES_TO_DISABLE_ON_BAT/AC and DEVICES_TO_ENABLE_ON_BAT/AC would therefore have to be completely replaced by ON_SAV/BAL/PRF

Yes, I only figured that out after the fact, you're entirely correct and great catch!

[linrunner]

@dusklinux unlike my announcement above, I left DEVICES_TO_DISABLE/ENABLE_ON_STARTUP as is; everything else has been implemented. See the commit for details. Please test it.

@Mylinde Back when profiles were introduced in 1.9.0, I was already aware of the dilemma of parameter suffixes vs. profiles. However, I had to weigh two risks against each other. We can certainly discuss this, because action is needed. Just please don't do it here in this PR.

[dusklinux]

This appears to a be a much better implementation on first glance, Will be testing this extensively by tomorrow at the latest. Will be sure to provide any feedback, negative or positive.